feat: add support for vlcm (offline software depots, cluster images)

[spacegospod]

Description

The goal of this PR is to provide users with the ability to configure custom images for clusters using vLCM.
To achieve that I am adding

1. A new resource for offline software depots. Support for online depots can be added at a later time.
   Only depots with source type "PULL" are supported. This is intentional and aims to discourage the use of the deprecated VUM functionality.
2. A new data source for base images. Declaring this data source allows users to retrieve the full list of available ESXi versions for their environment.
3. A new property for compute clusters that serves as an entry point for the vLCM configuration.
   It allows users to select a base image and a list of custom components from a depot.
   Configuring this property for the first time also enables vLCM on the cluster

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output of make test

Ran the following acceptance tests:

=== RUN   TestAccResourceVSphereComputeCluster_basic
--- PASS: TestAccResourceVSphereComputeCluster_basic (133.60s)
=== RUN   TestAccResourceVSphereComputeCluster_haAdmissionControlPolicyDisabled
--- PASS: TestAccResourceVSphereComputeCluster_haAdmissionControlPolicyDisabled (169.08s)
=== RUN   TestAccResourceVSphereComputeCluster_drsHAEnabled
--- PASS: TestAccResourceVSphereComputeCluster_drsHAEnabled (127.58s)
=== RUN   TestAccResourceVSphereComputeCluster_vlcm
--- PASS: TestAccResourceVSphereComputeCluster_vlcm (766.70s)
=== RUN   TestAccResourceVSphereComputeCluster_vsanDedupEnabled
--- PASS: TestAccResourceVSphereComputeCluster_vsanDedupEnabled (167.37s)
=== RUN   TestAccResourceVSphereComputeCluster_vsanCompressionEnabled
--- PASS: TestAccResourceVSphereComputeCluster_vsanCompressionEnabled (151.22s)
=== RUN   TestAccResourceVSphereComputeCluster_vsanPerfEnabled
--- PASS: TestAccResourceVSphereComputeCluster_vsanPerfEnabled (152.49s)
=== RUN   TestAccResourceVSphereComputeCluster_vsanPerfVerboseEnabled
--- PASS: TestAccResourceVSphereComputeCluster_vsanPerfVerboseEnabled (147.17s)
=== RUN   TestAccResourceVSphereComputeCluster_vsanPerfVerboseDiagnosticEnabled
--- PASS: TestAccResourceVSphereComputeCluster_vsanPerfVerboseDiagnosticEnabled (146.63s)
=== RUN   TestAccResourceVSphereComputeCluster_vsanUnmapEnabledwithVsanEnabled
--- PASS: TestAccResourceVSphereComputeCluster_vsanUnmapEnabledwithVsanEnabled (147.46s)
=== RUN   TestAccResourceVSphereComputeCluster_vsanUnmapDisabledwithVsanDisabled
--- PASS: TestAccResourceVSphereComputeCluster_vsanUnmapDisabledwithVsanDisabled (230.83s)
=== RUN   TestAccResourceVSphereComputeCluster_vsanDITEncryption
--- PASS: TestAccResourceVSphereComputeCluster_vsanDITEncryption (168.3)
=== RUN   TestAccResourceVSphereOfflineSoftwareDepot_basic
--- PASS: TestAccResourceVSphereOfflineSoftwareDepot_basic (168.36s)

Release Note

Release note for CHANGELOG:

Adding support for vLCM - a new resource for offline depots, a new data source for base images, new properties on clusters that allow users to do base image customizations

References

Closes #2142

[tenthirtyam]

Dependent on the next release of vmware/govmomi with vmware/govmomi#3377.

[tenthirtyam]

Hi Stoyan 👋🏻 -

Could you add the required documenation to the /website/docs/... directories for the new resource and data source?

I'll get a PR in for updating vmware/govmomi to v0.36.0 that released today with your upstream changes and then rebase this PR.

Ryan

[spacegospod]

Hi Stoyan 👋🏻 -

Could you add the required documenation to the /website/docs/... directories for the new resource and data source?

I'll get a PR in for updating vmware/govmomi to v0.36.0 that released today with your upstream changes and then rebase this PR.

Ryan

Thanks for taking care of the govmomi bump. I will add docs for the new entities

[tenthirtyam]

Rebased but the CI is failing:

--- FAIL: TestProvider (0.00s)
    provider_test.go:25: err: resource vsphere_offline_software_depot: key: ValidateFunc is for validating user input, there's nothing to validate on computed-only field
FAIL

[spacegospod]

Rebased but the CI is failing:

--- FAIL: TestProvider (0.00s)
    provider_test.go:25: err: resource vsphere_offline_software_depot: key: ValidateFunc is for validating user input, there's nothing to validate on computed-only field
FAIL

Silly me, I added validations on my computed properties

[tenthirtyam]

LGTM!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.