Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add moid attribute in vsphere_virtual_machine data source #1868

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

sestegra
Copy link
Contributor

@sestegra sestegra commented Mar 24, 2023

Description

data/vsphere_virtual_machine Add moid attribute to support result from data/vsphere_dynamic

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

- `data/vsphere_virtual_machine` Add `moid` attribute to support result from `data/vsphere_dynamic`

References

Closes #1867

@sestegra sestegra requested a review from a team as a code owner March 24, 2023 15:11
@github-actions github-actions bot added provider Type: Provider size/xs Relative Sizing: Extra-Small labels Mar 24, 2023
@sestegra sestegra changed the title Add moid attribute in vsphere_virtual_machine data source feat: Add moid attribute in vsphere_virtual_machine data source Mar 24, 2023
@tenthirtyam tenthirtyam added enhancement Type: Enhancement area/vm Area: Virtual Machines labels Mar 24, 2023
@tenthirtyam tenthirtyam added this to the v2.4.0 milestone Mar 24, 2023
sestegra and others added 2 commits April 13, 2023 14:53
Signed-off-by: Stéphane Este-Gracias <sestegra@gmail.com>
@github-actions github-actions bot added the size/m Relative Sizing: Medium label Apr 13, 2023
@appilon
Copy link
Contributor

appilon commented Apr 13, 2023

I rebased and added a test, had to add setting the moid so the other paths (lookup by name and by uuid) set it as well.

@appilon appilon merged commit fb9f18b into hashicorp:main Apr 13, 2023
@tenthirtyam
Copy link
Collaborator

thanks, alex!

@github-actions
Copy link

github-actions bot commented May 5, 2023

This functionality has been released in v2.4.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/vm Area: Virtual Machines enhancement Type: Enhancement provider Type: Provider size/m Relative Sizing: Medium size/xs Relative Sizing: Extra-Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for moid attribute in vsphere_virtual_machine data source
3 participants