-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.25.0 to 2.26.1 #1862
chore(deps): bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.25.0 to 2.26.1 #1862
Conversation
Well this is awkward, I'm getting the same error as #1858 , I have tested multiple times those branches at main, main always passes. This is incredibly weird... The whole thing is made a bit weirder because the virtual machine basic test doesn't exactly fit our typical testflow, normally we create, then import in other providers. For some reason proliferated throughout this provider we add a subsequent recreation of the basic config, which I don't see the benefit of, could just be triggering some weird edgecase bug in the test harness itself?? I just don't understand why upgrading either govmomi OR plugin-sdk means the test suddenly fails, I will try upgrading another dependency, could actually be some Golang core bug (occam's razor says no)? |
Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.25.0 to 2.26.1. - [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-sdk@v2.25.0...v2.26.1) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-sdk/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
61eca75
to
f820a3b
Compare
similar to #1858 , things seem to pass when running the bump off of main 🤷♂️
I'm going to approve and merge, and run again from main, and hope this weirdness doesn't happen again |
This functionality has been released in v2.4.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Bumps github.com/hashicorp/terraform-plugin-sdk/v2 from 2.25.0 to 2.26.1.
Release notes
Sourced from github.com/hashicorp/terraform-plugin-sdk/v2's releases.
Changelog
Sourced from github.com/hashicorp/terraform-plugin-sdk/v2's changelog.
Commits
1798ae4
Update changelog3232543
helper/resource: Add missing equals for type aliases (#1177)773d73e
Update changelog53a4ec4
build(deps): Bump github.com/zclconf/go-cty from 1.13.0 to 1.13.1 (#1174)dc034f3
website: removed non-sdk best practice documentation (#1170)32e6278
build(deps): Bump actions/setup-go from 3.5.0 to 4.0.0 (#1173)ec906fd
build(deps): Bump actions/checkout from 3.3.0 to 3.4.0 (#1172)adb9dd8
Fix migration to terraform-plugin-testing causes panic in existing test suite...4d62d1f
build(deps): Bump github.com/hashicorp/terraform-json (#1169)7145057
build(deps): Bump github.com/hashicorp/hcl/v2 from 2.16.1 to 2.16.2 (#1168)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)