Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.25.0 to 2.26.1 #1862

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 22, 2023

Bumps github.com/hashicorp/terraform-plugin-sdk/v2 from 2.25.0 to 2.26.1.

Release notes

Sourced from github.com/hashicorp/terraform-plugin-sdk/v2's releases.

v2.26.1

BUG FIXES:

  • helper/resource: Prevented build errors with type aliasing added in v2.26.0 (#1176)

v2.26.0

NOTES:

  • This Go module has been updated to Go 1.19 per the Go support policy. Any consumers building on earlier Go versions may experience errors. (#1163)
  • helper/resource: Deprecated PrefixedUniqueId() and UniqueId(). Use the helper/id package instead. These deprecations are to assist in migrating to terraform-plugin-testing (#1167)
  • helper/resource: Deprecated RetryContext(), StateChangeConf, and associated *Error types. Use the helper/retry package instead. These deprecations are to assist in migrating to terraform-plugin-testing (#1167)

ENHANCEMENTS:

  • helper/id: New helper/id package added. resource.PrefixedUniqueId() and resource.UniqueId() are deprecated, helper/id should be used instead. helper/resource now contains aliases to the migrated code (#1167)
  • helper/retry: New helper/retry package added. resource.RetryContext(), resource.StateChangeConf, and associated *Error types are deprecated, helper/retry should be used instead. `helper/resource now contains aliases to the migrated code (#1167)
Changelog

Sourced from github.com/hashicorp/terraform-plugin-sdk/v2's changelog.

2.26.1 (March 21, 2023)

BUG FIXES:

  • helper/resource: Prevented build errors with type aliasing added in v2.26.0 (#1176)

2.26.0 (March 20, 2023)

NOTES:

  • This Go module has been updated to Go 1.19 per the Go support policy. Any consumers building on earlier Go versions may experience errors. (#1163)
  • helper/resource: Deprecated PrefixedUniqueId() and UniqueId(). Use the helper/id package instead. These deprecations are to assist in migrating to terraform-plugin-testing (#1167)
  • helper/resource: Deprecated RetryContext(), StateChangeConf, and associated *Error types. Use the helper/retry package instead. These deprecations are to assist in migrating to terraform-plugin-testing (#1167)

ENHANCEMENTS:

  • helper/id: New helper/id package added. resource.PrefixedUniqueId() and resource.UniqueId() are deprecated, helper/id should be used instead. helper/resource now contains aliases to the migrated code (#1167)
  • helper/retry: New helper/retry package added. resource.RetryContext(), resource.StateChangeConf, and associated *Error types are deprecated, helper/retry should be used instead. `helper/resource now contains aliases to the migrated code (#1167)
Commits
  • 1798ae4 Update changelog
  • 3232543 helper/resource: Add missing equals for type aliases (#1177)
  • 773d73e Update changelog
  • 53a4ec4 build(deps): Bump github.com/zclconf/go-cty from 1.13.0 to 1.13.1 (#1174)
  • dc034f3 website: removed non-sdk best practice documentation (#1170)
  • 32e6278 build(deps): Bump actions/setup-go from 3.5.0 to 4.0.0 (#1173)
  • ec906fd build(deps): Bump actions/checkout from 3.3.0 to 3.4.0 (#1172)
  • adb9dd8 Fix migration to terraform-plugin-testing causes panic in existing test suite...
  • 4d62d1f build(deps): Bump github.com/hashicorp/terraform-json (#1169)
  • 7145057 build(deps): Bump github.com/hashicorp/hcl/v2 from 2.16.1 to 2.16.2 (#1168)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner March 22, 2023 05:16
@dependabot dependabot bot added dependencies Type: Dependencies go labels Mar 22, 2023
@github-actions github-actions bot added size/m Relative Sizing: Medium and removed dependencies Type: Dependencies labels Mar 22, 2023
@tenthirtyam tenthirtyam added dependencies Type: Dependencies chore Type: Chore labels Mar 24, 2023
@tenthirtyam tenthirtyam requested a review from appilon March 28, 2023 21:18
@tenthirtyam tenthirtyam added this to the v2.4.0 milestone Mar 28, 2023
@appilon
Copy link
Contributor

appilon commented Apr 12, 2023

Well this is awkward, I'm getting the same error as #1858 , I have tested multiple times those branches at main, main always passes. This is incredibly weird... I can try and see if both govmomi and plugin-sdk share some tertiary dependency that had a critical security fix (explaining why the regression is in both PRs)... that somehow causes this regression? govmomi brings no transitive dependencies 🤷‍♂️

The whole thing is made a bit weirder because the virtual machine basic test doesn't exactly fit our typical testflow, normally we create, then import in other providers. For some reason proliferated throughout this provider we add a subsequent recreation of the basic config, which I don't see the benefit of, could just be triggering some weird edgecase bug in the test harness itself?? I just don't understand why upgrading either govmomi OR plugin-sdk means the test suddenly fails, I will try upgrading another dependency, could actually be some Golang core bug (occam's razor says no)?

@appilon appilon added the do-not-merge Status: Draft, Do Not Merge label Apr 12, 2023
Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.25.0 to 2.26.1.
- [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases)
- [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-plugin-sdk@v2.25.0...v2.26.1)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/terraform-plugin-sdk/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/hashicorp/terraform-plugin-sdk/v2-2.26.1 branch from 61eca75 to f820a3b Compare April 12, 2023 19:25
@github-actions github-actions bot removed the dependencies Type: Dependencies label Apr 12, 2023
@appilon
Copy link
Contributor

appilon commented Apr 12, 2023

similar to #1858 , things seem to pass when running the bump off of main 🤷‍♂️

=== RUN   TestAccResourceVSphereVirtualMachine_basic
--- PASS: TestAccResourceVSphereVirtualMachine_basic (45.71s)

I'm going to approve and merge, and run again from main, and hope this weirdness doesn't happen again

@appilon appilon merged commit 6dca29d into main Apr 12, 2023
@appilon appilon deleted the dependabot/go_modules/github.com/hashicorp/terraform-plugin-sdk/v2-2.26.1 branch April 12, 2023 19:35
@appilon appilon removed the do-not-merge Status: Draft, Do Not Merge label Apr 13, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

This functionality has been released in v2.4.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore Type: Chore size/m Relative Sizing: Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants