fix: Local iso upload in content library item

[juanvalino]

Description

This fixes local iso uploading in content library item.

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Release Note

Release note for CHANGELOG:

Fix content library item local iso upload

References

Resolves #1664

[hashicorp-cla]

All committers have signed the CLA.

[tenthirtyam]

Hi @juanvalino,

Thanks for the contribution. The GHA tests are failing for the following:

gofmt needs running on the following files:
8
./vsphere/internal/helper/contentlibrary/content_library_helper.go
9
You can use the command: `make fmt` to reformat code.
10
make: *** [GNUmakefile:46: fmtcheck] Error 1
11
Error: Process completed with exit code 2.

Could you please run go fmt against the changed file and commit? That should take care of the issue.

Ryan Johnson
Staff II Solutions Architect | VMware, Inc.

[juanvalino]

@tenthirtyam I fixed the code format and now the tests seem to pass.

[tenthirtyam]

Confirmed that this fix addresses the issue and works quite nicely. Tested with multiple ISOs being uploaded at the same time w/o any issue.

LGTM! 🚀

[juanvalino]

@tenthirtyam, do you have any estimation for this merge?

[tenthirtyam]

Hi @juanvalino,

I've tagged the pull request for the v2.2.0 milestone and provider my review as a project collaborator. It still needs a review from the project maintainer ( @appilon ) before it can be merged.

Ryan Johnson
Staff II Solutions Architect | VMware, Inc.

[tenthirtyam]

Thanks, Alex!

Ryan Johnson
Staff II Solutions Architect | VMware, Inc.

[github-actions]

This functionality has been released in v2.2.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.