Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resource/content_library_item docs #1586

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Update resource/content_library_item docs #1586

merged 2 commits into from
Feb 16, 2022

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Feb 12, 2022

Description

Update resource/content_library_item docs.

  • Improves content and clarity.
  • Simplifies using generic Ubuntu examples
  • Adds examples for .iso and source_uuid.
  • Adds missing type argument.

Release Note

resource/content_library_item: Documentation improvements [GH-1586]

References

Content supersedes #1585. Merge after (or in lieu of.)

@tenthirtyam tenthirtyam added documentation Type: Documentation needs-review Status: Pull Request Needs Review labels Feb 12, 2022
@tenthirtyam tenthirtyam requested a review from appilon February 12, 2022 04:41
@tenthirtyam tenthirtyam self-assigned this Feb 12, 2022
@github-actions github-actions bot added the size/m Relative Sizing: Medium label Feb 12, 2022
@tenthirtyam tenthirtyam added this to the v2.1.0 milestone Feb 14, 2022
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo, otherwise LGTM

website/docs/r/content_library_item.html.markdown Outdated Show resolved Hide resolved
@tenthirtyam
Copy link
Collaborator Author

Resolved!

@tenthirtyam tenthirtyam requested a review from appilon February 16, 2022 02:51
Ryan Johnson and others added 2 commits February 15, 2022 22:02
Update `resource/content_library_item` docs.
- Improves content and clarity.
- Simplifies using generic Ubuntu examples
- Adds examples for `.iso` and `source_uuid`.
- Adds missing `type` argument.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
Co-authored-by: appilon <apilon@hashicorp.com>
@appilon appilon merged commit c657525 into hashicorp:master Feb 16, 2022
@tenthirtyam tenthirtyam deleted the docs-resource-content-library-item branch February 16, 2022 03:19
@tenthirtyam
Copy link
Collaborator Author

Many thanks, @appilon! 🚀

@tenthirtyam tenthirtyam removed the needs-review Status: Pull Request Needs Review label Feb 16, 2022
@github-actions
Copy link

github-actions bot commented Mar 2, 2022

This functionality has been released in v2.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Apr 2, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Type: Documentation size/m Relative Sizing: Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants