Update default GOS to otherGuest64 from other-64

[tenthirtyam]

Description

• Updates the default GOS to otherGuest64 from invalid other-64.
• Updates guest_id and alternate_guest_name to correctly mention otherGuest and otherGuest64 - not other and other-64
• Also updates the descriptions in virtual_machine_config_structure.go with more inclusive/accurate terminology, cleaner structure, and correct component proper name.

Release Note

Release note for CHANGELOG:

Updates the default GOS to `otherGuest64` from invalid `other-64`.

References

Closes: #1263

vSphere Web Services API: Enum - VirtualMachineGuestOsIdentifier

[appilon]

@tenthirtyam Was other/other-64 ever correct in previous versions of vsphere < 7? Particularly for version 6.5+ (which is technically still supported by the provider). If not I will merge, if yes, then we may have to make the descriptions more detailed and make do an if else in the code based on the detected version

[tenthirtyam]

The introduction timeline of other / other64 is not mentioned in vim.vm.GuestOsDescriptor.GuestOsIdentifier spec. I suspect that it's been present for at least vSphere 6.5 and later but I do not have a v6.5 testbed to validate this assumption.

other-64 does not exist in the spec.

Ryan

[appilon]

I get the sense from link you shared that other was never a valid identifier? so let's go with this change

[tenthirtyam]

Yes, that's correct @appilon.

[github-actions]

This functionality has been released in v2.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.