This repository has been archived by the owner on Nov 14, 2020. It is now read-only.
Travis: Build agains multiple Postgres version + fix bugs #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This support multiple version of Postgres (from 8.4 to latest)
There's a feature flags system which allows to manage multiple Postgres versions but the parsed version was not correctly set in Client. So all the `featureSupported(XXX)` was returning false.
Some of the SQL queries were wrong as they were using statement parameters (i.e.: $1) where it's not possible to do so.
The postgresql_extension resource uses "CREATE EXTENSION" command which is not available before Postgres 9.1 This also disables tests (for the same versions) in order to build travis tests against multiple versions of Postgres (including 8.4)
ghost
added
the
paultyng
reviewed
Feb 8, 2019
| @@ -0,0 +1,6 @@ | |||
| export TF_ACC=true | |||
There was a problem hiding this comment.
You shouldn't need this here if you are running make testacc
There was a problem hiding this comment.
@paultyng Indeed, but when I run some tests manually during development I use to source tests/env.sh then I'm able to run go test ... to target specific tests.
There was a problem hiding this comment.
I typically just do:
TESTARGS="-cover -run 'MyTest'" make testaccBut feel free to merge if you prefer your style.
paultyng
approved these changes
Feb 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance tests was not run in Travis so I configured Travis to start Postgres server in a Docker container (with a Matrix of versions from 8.4 to latest) and enable acceptance tests against it.
By running these tests, I discovered multiple bugs that I fixed:
CREATE EXTENSIONdoes not exists before this version)fix #35