Skip to content
This repository has been archived by the owner on Nov 14, 2020. It is now read-only.

[add] set statement_timeout to role #105

Merged
merged 4 commits into from
Dec 26, 2019
Merged

[add] set statement_timeout to role #105

merged 4 commits into from
Dec 26, 2019

Conversation

mced
Copy link
Contributor

@mced mced commented Dec 5, 2019 •
edited
Loading

set statement_timeout to role

statement_timeout (integer)
Abort any statement that takes more than the specified number of milliseconds, starting from the time the command arrives at the server from the client.

@ghost ghost added the size/S label Dec 5, 2019
@ghost ghost added size/M and removed size/S labels Dec 6, 2019
cyrilgdn
cyrilgdn suggested changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@cyrilgdn cyrilgdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mced ,

Thanks for working on this 👍

Just two comments on it and it'll be good!

postgresql/resource_postgresql_role.go Outdated Show resolved Hide resolved
postgresql/resource_postgresql_role.go Outdated Show resolved Hide resolved
@mced
[enh] return error & handle reset statement_timeout
bd07b51 
Signed-off-by: Cédric Menassa <cedric.menassa@gmail.com>
@mced
Copy link
Contributor Author

mced commented Dec 23, 2019

That makes sense, thanks for your comments

@ghost ghost removed the waiting-response label Dec 23, 2019
cyrilgdn
cyrilgdn suggested changes Dec 23, 2019
View reviewed changes
Copy link
Contributor

@cyrilgdn cyrilgdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still one minor comment (sorry...) and it will be perfect!

postgresql/resource_postgresql_role.go Outdated Show resolved Hide resolved
@mced
[enh] wrap error in reading statement_timeout
3cd9a6b 
Signed-off-by: Cédric Menassa <cedric.menassa@gmail.com>
cyrilgdn
cyrilgdn approved these changes Dec 26, 2019
View reviewed changes
Copy link
Contributor

@cyrilgdn cyrilgdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your work 👍 !

@cyrilgdn cyrilgdn merged commit 43240b6 into hashicorp:master Dec 26, 2019
@mced
Copy link
Contributor Author

mced commented Jan 3, 2020

There is something I don't get...
I see that you released v1.4.0 version including this feature but when I added statement_timeout to postgresql_role after upgrading postgresql provider: I still get this error: Error: Unsupported argument.

Do you know why ?

@cyrilgdn
Copy link
Contributor

cyrilgdn commented Jan 5, 2020

@mced v1.4.0 does not include this feature unfortunately. I'll ask for a new release next week, I'll inform you here when it's done!

@mced
Copy link
Contributor Author

mced commented Feb 21, 2020

@cyrilgdn No new release from last year ?

@cyrilgdn
Copy link
Contributor

cyrilgdn commented Feb 21, 2020 •
edited
Loading

@mced Sorry for the delay, I thought I would have more time to work other PRs to include them in the release but it was not the case. I'll ask for release right now so v1.5.0 should be released today or Monday.

@mced
Copy link
Contributor Author

mced commented Feb 21, 2020

Thank you @cyrilgdn 👍

@cyrilgdn
Copy link
Contributor

@mced v1.5.0 has been released today! Sorry again for the delay.

@tomelliff tomelliff mentioned this pull request Feb 25, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyrilgdn cyrilgdn cyrilgdn approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mced @cyrilgdn