-
Notifications
You must be signed in to change notification settings - Fork 64
Conversation
@mcuadros going to trust you've done due diligence here, as it falls on you to maintain this after merging 😂 ❤️ , however would you mind adding a comment with the acceptance test output for the provider? Thanks! |
This provider doesn't have any acceptance test, since only generates a JSON string. |
@mcuadros thanks a lot for the PR! I gave it a shot locally, and have (so far) just one suggestion, namely to mark
|
@s-urbaniak the changes are massive, on several resources, so I rather not having any deprecated as the |
@mcuadros sounds good! if two separate versions are going to be available, then that is a viable approach. Thanks again! |
@mcuadros another litmus test. ignition failed on during install with the following error:
This fixes it on top of this PR:
|
Test Output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting merge until comments above are resolved, however.
@mcuadros this ready to be merged now? |
This is the implementation using ignition 2.1.
New resources:
ignition_directory
ignition_link
Updated resources:
ignition_config
ignition_filesystem
ignition_systemd_unit
ignition_user
Fixes #8