Move Bigtable config to cluster block.

[paddycarver]

Match the bigtable_instance resource to the API structure, deprecating
the inlined config parameters. This is a complicated deprecation,
because we don't want to ForceNew when updating to use the new
undeprecated fields, but we want to ForceNew if they change.

This is achieved using a CustomizeDiff.

[rileykarson]

Can you add a test with multiple clusters?

Does using a default zone make sense in the multiple-cluster world? Can we make a Cloud Bigtable with 2 clusters in the same zone? I don't think that makes sense and they should be in multiple zones, so the API probably won't allow it.

[paddycarver]

Can you add a test with multiple clusters?

Does using a default zone make sense in the multiple-cluster world? Can we make a Cloud Bigtable with 2 clusters in the same zone? I don't think that makes sense and they should be in multiple zones, so the API probably won't allow it.

I have no idea. Since this wasn't supposed to be enhancement work, just deprecation, how would you feel about me just setting MaxItems to 1 for now, and we can sort through the enhancements at a later date? At this point, I just want to get the config in the right shape, I don't really care about supporting multiple clusters today. We could do that work some other time.

[rileykarson]

SGTM. We should have that done for 2.0.0 though probably and not just "some other time"? Or removing the default zone done then at least, as it's a breaking change.

[paddycarver]

I'd be down for removing getZone in 2.0.0, but we can't do that today.

[rileykarson]

Oh yup! That's what I meant by that*

[paddycarver]

Cool, I already have #1672 in the 2.0.0 milestone, so we've got an issue to track that enhancement.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!