Add import support for google_compute_image. #194
Conversation
google/resource_compute_image.go
Outdated
| @@ -195,3 +213,9 @@ func resourceComputeImageDelete(d *schema.ResourceData, meta interface{}) error | |||
| d.SetId("") | |||
| return nil | |||
| } | |||
|
|
|||
| func resourceComputeImageImportState(d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) { | |||
| d.Set("create_timeout", computeImageCreateTimeoutDefault) | |||
There was a problem hiding this comment.
Can you explain why this is necessary instead of setting create_timeout on read every time?
There was a problem hiding this comment.
Added a comment explaining why.
Another option would be to set the create_timeout in the read method if it is not set but I prefer not cluttering the read method logic with logic specific to import.
There was a problem hiding this comment.
Hmm, so actually I think we should stop this from being ForceNew. Just from thinking about it logically, it's the amount of time we're willing to wait for the instance to create. IMO, changing it doesn't actually mean I want to create a new one, it just means that should it recreate for some other reason, we would want to wait that long. Does that seem right? If so we can remove ForceNew and just never do a d.Set on it.
There was a problem hiding this comment.
Agree for the ForceNew part, I will do it.
However, if we don't set create_timeout to the default value on import, then, after importing, the user will have a "plan diff" with:
~ google_compute_image.web-image
create_timeout: "" => "4"
The update is fast (only update the value locally). I am wondering if this is the expected behavior that after an import, we may have a diff that we can't fix without either running apply or fiddling with the state file.
Thoughts?
There was a problem hiding this comment.
Oh, you're right. In this case the way you've done it is probably correct, then.
There was a problem hiding this comment.
I removed the ForceNew from the create_timeout field.
| VM image can be imported using the `name`, e.g. | ||
|
|
||
| ``` | ||
| $ terraform import google_compute_image.web-image image1 |
There was a problem hiding this comment.
Can you change image1 to my-custom-image since that's the name in the example?
|
Looks good, thanks! |
* Add import support for google_compute_image. * Added comment explaning why we set the create_timeout in the import state method * Don't ForceNew for create_timeout field * Update image name in import documentation
* Add import support for google_compute_image. * Added comment explaning why we set the create_timeout in the import state method * Don't ForceNew for create_timeout field * Update image name in import documentation
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
issue #182
/cc @danawillow