Add support for pod security policy #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nat-henderson
approved these changes
Mar 14, 2018
google/resource_container_cluster.go
Outdated
| @@ -1063,6 +1090,32 @@ func resourceContainerClusterUpdate(d *schema.ResourceData, meta interface{}) er | |||
| d.SetPartial("logging_service") | |||
| } | |||
|
|
|||
| // Disable update support for now: https://issuetracker.google.com/74063492 | |||
There was a problem hiding this comment.
Is this the best way? I feel like maybe we might want to just use regular git / github for this, pull it out into its own branch, and leave the PR open with a note that it should be merged when the bug is closed. Commented-out-code makes me nervous.
There was a problem hiding this comment.
Yeah, that's a better idea. I'll do that now.
ashish-amarnath
pushed a commit
to ashish-amarnath/terraform-provider-google
that referenced
this pull request
Mar 20, 2018
* move setid calls back * add support for pod security policy * pod security policy docs * Revert "move setid calls back" This reverts commit 0c7b2db. * cleanup * remove comments about disabling update
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
* move setid calls back * add support for pod security policy * pod security policy docs * Revert "move setid calls back" This reverts commit 0c7b2db. * cleanup * remove comments about disabling update
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1168