Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors #3553

Merged
merged 1 commit into from
May 30, 2019
Merged

Conversation

stuartleeks
Copy link
Contributor

Code tweaks to fix build errors:

$ make build
==> Checking that code complies with gofmt requirements...
go install
# github.com/terraform-providers/terraform-provider-azurerm/azurerm
azurerm/data_source_redis_cache.go:196:29: meta.(*ArmClient).redisClient undefined (type *ArmClient has no field or method redisClient)
azurerm/data_source_redis_cache.go:247:43: meta.(*ArmClient).redisPatchSchedulesClient undefined (type *ArmClient has no field or method redisPatchSchedulesClient)
GNUmakefile:13: recipe for target 'build' failed
make: *** [build] Error 2

Changes based on looking at the history here

@ghost ghost added the size/XS label May 30, 2019
@stuartleeks
Copy link
Contributor Author

@katbyte @tombuildsstuff - I'm getting issues with master builds failing. The couple of tweaks in this PR fix it for me (and the CI build succeeded :-))

@tombuildsstuff
Copy link
Contributor

@stuartleeks thanks for spotting/fixing this 👍

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for spotting/fixing this @stuartleeks

@tombuildsstuff tombuildsstuff added this to the v1.30.0 milestone May 30, 2019
@tombuildsstuff tombuildsstuff merged commit 4d6605a into hashicorp:master May 30, 2019
@ghost
Copy link

ghost commented Jun 20, 2019

This has been released in version 1.30.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.30.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 30, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants