-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_data_factory_linked_service_synapse
#9928
New Resource: azurerm_data_factory_linked_service_synapse
#9928
Conversation
azurerm_data_factory_linked_service_synapse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr @allantargino, overall this looks good but i have left some comments on schema and resource IDs inline to address. Once they have been fixed up this should be good to merge
azurerm/internal/services/datafactory/data_factory_linked_service_synapse_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/datafactory/data_factory_linked_service_synapse_resource.go
Show resolved
Hide resolved
azurerm/internal/services/datafactory/data_factory_linked_service_synapse_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/datafactory/data_factory_linked_service_synapse_resource.go
Show resolved
Hide resolved
azurerm/internal/services/datafactory/data_factory_linked_service_synapse_resource.go
Show resolved
Hide resolved
azurerm/internal/services/datafactory/data_factory_linked_service_synapse_resource.go
Show resolved
Hide resolved
azurerm/internal/services/datafactory/data_factory_linked_service_synapse_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/datafactory/data_factory_linked_service_synapse_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/datafactory/data_factory_linked_service_synapse_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/datafactory/data_factory_linked_service_synapse_resource_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @allantargino - LGTM 👍
Thanks for the review, @katbyte! Happy new year :) |
This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.42.0"
}
# ... other configuration ... |
…10032) fixes #6481 Following the same interface introduced at #9928, where we added key_vault_password property on azurerm_data_factory_linked_service_synapse to support passwords stored in Key Vault secret through an ADF linked service, this PR adds the same capability to azurerm_data_factory_linked_service_sql_server.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
fix #9919
This PR introduces the new resource
azurerm_data_factory_linked_service_synapse
.You can use a connection string with password:
or use a key vault linked service to store the password: