Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_data_factory_linked_service_synapse #9928

Merged

Conversation

allantargino
Copy link
Contributor

@allantargino allantargino commented Dec 18, 2020

fix #9919

This PR introduces the new resource azurerm_data_factory_linked_service_synapse.

You can use a connection string with password:

resource "azurerm_data_factory_linked_service_synapse" "example" {
  name = "adf-link-synapse"
  resource_group_name = azurerm_resource_group.example.name
  data_factory_name = azurerm_data_factory.example.name

  connection_string = "data source=serverhostname;initial catalog=master;user id=testUser;Password=...;Timeout=30;"
}

or use a key vault linked service to store the password:

resource "azurerm_data_factory_linked_service_synapse" "example" {
  name                = "adf-link-synapse"
  resource_group_name = azurerm_resource_group.example.name
  data_factory_name   = azurerm_data_factory.example.name

  connection_string = "data source=serverhostname;initial catalog=master;user id=testUser;Timeout=30;"
  key_vault_password {
    linked_service_name  = "adf-link-key-vault"
    secret_name = "synapse-connection-string"
  }
}

@allantargino allantargino changed the title Adding azurerm_data_factory_linked_service_synapse resource Adding support for azurerm_data_factory_linked_service_synapse resource Dec 18, 2020
@allantargino allantargino changed the title Adding support for azurerm_data_factory_linked_service_synapse resource New Resource: azurerm_data_factory_linked_service_synapse Dec 18, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @allantargino, overall this looks good but i have left some comments on schema and resource IDs inline to address. Once they have been fixed up this should be good to merge

@katbyte katbyte added this to the v2.42.0 milestone Dec 31, 2020
@allantargino allantargino requested a review from katbyte January 1, 2021 16:19
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @allantargino - LGTM 👍

@katbyte katbyte merged commit 69aca73 into hashicorp:master Jan 1, 2021
katbyte added a commit that referenced this pull request Jan 1, 2021
@allantargino
Copy link
Contributor Author

Thanks for the review, @katbyte! Happy new year :)

@allantargino allantargino deleted the adf-linked-service-synapse-resource branch January 2, 2021 03:03
@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.42.0"
}
# ... other configuration ...

katbyte pushed a commit that referenced this pull request Jan 13, 2021
…10032)

fixes #6481

Following the same interface introduced at #9928, where we added key_vault_password property on azurerm_data_factory_linked_service_synapse to support passwords stored in Key Vault secret through an ADF linked service, this PR adds the same capability to azurerm_data_factory_linked_service_sql_server.
@ghost
Copy link

ghost commented Feb 1, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Azure Data Factory Linked Service to Synapse resource
2 participants