Raise limit of destination_ports of network_rule_collection for azurerm_firewall_policy_rule_collection_group #9490
Conversation
neil-yechenwei
changed the title
neil-yechenwei
changed the title
There was a problem hiding this comment.
Thanks for the PR @neil-yechenwei - I think we can simplify this and share the functino between the properties with a small change/ See my comment inline
| "strconv" | ||
| ) | ||
|
|
||
| func FirewallPolicyNetworkRulePort(i interface{}, k string) (warnings []string, errors []error) { |
There was a problem hiding this comment.
Instead of creating an entire new function could we add this to the validate package as validate.PortOrPortRangeWithin(1,65535) and then both properties can share it?
|
@katbyte , thanks for your comments. I've updated code. Please have an another look. |
|
This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.42.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
fixes #9304
--- PASS: TestAccAzureRMFirewallPolicyRuleCollectionGroup_requiresImport (153.90s)
--- PASS: TestAccAzureRMFirewallPolicyRuleCollectionGroup_basic (194.10s)
--- PASS: TestAccAzureRMFirewallPolicyRuleCollectionGroup_complete (202.27s)
--- PASS: TestAccAzureRMFirewallPolicyRuleCollectionGroup_update (269.51s)