azurerm_cdn_endpoint - delivery_rule condition optional match_values

[magodo]

When the delivery_rule condition operator is set to Any, we should
not pass any match_values at all.

Fixes #8770

[jackofallops]

Hi @magodo
Thanks for this PR. What does the API do if presented with a payload that doesn't use the Any operator and no match_rules are present? It feels remiss to trade one API error for another? If it does error, this should be addressed in code or documentation? WDYT?

[magodo]

@jackofallops You're right, I should have mentioned it in the document to make it clear. Whilst I think it is not necessarily to check in the code as it will fail in the API anyway, there is no too much benefit to fail a bit earlier just before sending the request.

[DeltaOffset]

Changing from Required to Optional setting for match_values when the operator is "Any" should be a valid fix for this scenario. IMHO

[tombuildsstuff]

hi @magodo

Taking a look through whilst this seems ok, can we add some tests for this to confirm that these changes are sufficient?

Thanks!

[magodo]

@tombuildsstuff Thank you for reviewing! I have added a test to cover all the conditions which has match set to Any.

Test Result

💤 make testacc TEST=./azurerm/internal/services/cdn/tests TESTARGS='-run TestAccAzureRMCdnEndpoint_deliveryRuleOptionalMatchValue'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/cdn/tests -v -run TestAccAzureRMCdnEndpoint_deliveryRuleOptionalMatchValue -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMCdnEndpoint_deliveryRuleOptionalMatchValue
=== PAUSE TestAccAzureRMCdnEndpoint_deliveryRuleOptionalMatchValue
=== CONT  TestAccAzureRMCdnEndpoint_deliveryRuleOptionalMatchValue
--- PASS: TestAccAzureRMCdnEndpoint_deliveryRuleOptionalMatchValue (445.78s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/cdn/tests   445.901s

[DeltaOffset]

Guys Is this going to be merged soon? I Will like to import my cdn rules

[katbyte]

@magodo - could we fix the merge conflicts? once thats done i think this is good to merge

[magodo]

@katbyte I've resolved the conflicts, please take another look!

💤 make testacc TEST=./azurerm/internal/services/cdn TESTARGS='-run TestAccCdnEndpoint_deliveryRuleOptionalMatchValue'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/cdn -v -run TestAccCdnEndpoint_deliveryRuleOptionalMatchValue -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccCdnEndpoint_deliveryRuleOptionalMatchValue
=== PAUSE TestAccCdnEndpoint_deliveryRuleOptionalMatchValue
=== CONT  TestAccCdnEndpoint_deliveryRuleOptionalMatchValue
--- PASS: TestAccCdnEndpoint_deliveryRuleOptionalMatchValue (504.39s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/cdn 504.426s

[katbyte]

Thanks @magodo - aside from the docs needed to be updated this LGTM 👍

[ghost]

This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.42.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!