Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_cosmosdb_account modifying geo_location no longer triggers a recreation of the resource #7217

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Jun 4, 2020

Fixes #3532

@ghost ghost added the size/XS label Jun 4, 2020
@mbfrahry mbfrahry requested a review from a team June 4, 2020 21:26
@mbfrahry mbfrahry added this to the v2.14.0 milestone Jun 4, 2020
@katbyte
Copy link
Collaborator

katbyte commented Jun 8, 2020

related to #4315

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Is it worth adding an update test that exercises the add/remove location code now this functionality is available?

@mbfrahry
Copy link
Member Author

mbfrahry commented Jun 9, 2020

Yes! Definitely forgot that one

@ghost ghost added size/M and removed size/XS labels Jun 9, 2020
@mbfrahry mbfrahry changed the title azurerm_cosmosdb_account modifying geo_location should no longer trigger a recreation of the resource azurerm_cosmosdb_account modifying geo_location no longer triggers a recreation of the resource Jun 9, 2020
@mbfrahry mbfrahry merged commit e13f0d8 into master Jun 9, 2020
@mbfrahry mbfrahry deleted the b-cosmosdb-account-geo-location branch June 9, 2020 15:33
mbfrahry added a commit that referenced this pull request Jun 9, 2020
@ghost
Copy link

ghost commented Jun 11, 2020

This has been released in version 2.14.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.14.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding an additional geo_location to an azurerm_cosmosdb_account should not require replacement
3 participants