`azurerm_api_management` add `sku_name` `Consumption_0` #6868

yupwei68 · 2020-05-12T07:15:47Z

mbfrahry

Hey @yupwei68, this change looks good but we will run into a similar problem as the one listed in #6733 where Consumption_0 doesn't work when specified. We'll need to get that working in this PR before we can merge

yupwei68 · 2020-05-13T01:39:47Z

@mbfrahry But Consumption_0 works, and it's in the unit test.

mbfrahry · 2020-05-13T07:13:39Z

Whist the unit test passes, I don't believe an acceptance test will. Do you mind adding an acceptance test that provisions the resource with Consumption_0 to confirm that one gets provisioned successfully.

azurerm/internal/services/apimanagement/validate/api_management_test.go

katbyte

see comments above

yupwei68 · 2020-05-14T06:18:16Z

Hi @mbfrahry ,you're right. Changes have been pushed to get Consumption_0 passed. The tests bellow have passed.

=== RUN   TestAccAzureRMApiManagement_basic
=== PAUSE TestAccAzureRMApiManagement_basic
=== CONT  TestAccAzureRMApiManagement_basic
--- PASS: TestAccAzureRMApiManagement_basic (2534.08s)
=== RUN   TestAccAzureRMApiManagement_requiresImport
=== PAUSE TestAccAzureRMApiManagement_requiresImport
=== CONT  TestAccAzureRMApiManagement_requiresImport
--- PASS: TestAccAzureRMApiManagement_requiresImport (2480.47s)
=== RUN   TestAccAzureRMApiManagement_customProps
=== PAUSE TestAccAzureRMApiManagement_customProps
=== CONT  TestAccAzureRMApiManagement_customProps
--- PASS: TestAccAzureRMApiManagement_customProps (2195.22s)
=== RUN   TestAccAzureRMApiManagement_signInSignUpSettings
=== PAUSE TestAccAzureRMApiManagement_signInSignUpSettings
=== CONT  TestAccAzureRMApiManagement_signInSignUpSettings
--- PASS: TestAccAzureRMApiManagement_signInSignUpSettings (2599.11s)
=== RUN   TestAccAzureRMApiManagement_policy
=== PAUSE TestAccAzureRMApiManagement_policy
=== CONT  TestAccAzureRMApiManagement_policy
--- PASS: TestAccAzureRMApiManagement_policy (2873.39s)
=== RUN   TestAccAzureRMApiManagement_consumption
=== PAUSE TestAccAzureRMApiManagement_consumption
=== CONT  TestAccAzureRMApiManagement_consumption
--- PASS: TestAccAzureRMApiManagement_consumption (177.89s)
=== RUN   TestAccAzureRMApiManagement_identityUserAssigned
=== PAUSE TestAccAzureRMApiManagement_identityUserAssigned
=== CONT  TestAccAzureRMApiManagement_identityUserAssigned
--- PASS: TestAccAzureRMApiManagement_identityUserAssigned (2011.97s)

tombuildsstuff

hi @yupwei68

Thanks for this PR - I've taken a look through and left some comments inline, but we'll need to update the approach used here slightly to account for removing the blocks in a subsequent update - I've left comments inline with more details

Thanks!

azurerm/internal/services/apimanagement/api_management_resource.go

yupwei68 · 2020-05-18T05:51:35Z

hi @katbyte @tombuildsstuff Except the open comments, other changes have been pushed. Please continue your reviewing.

=== RUN   TestAccAzureRMApiManagement_basic
=== PAUSE TestAccAzureRMApiManagement_basic
=== CONT  TestAccAzureRMApiManagement_basic
--- PASS: TestAccAzureRMApiManagement_basic (2109.62s)
=== RUN   TestAccAzureRMApiManagement_requiresImport
=== PAUSE TestAccAzureRMApiManagement_requiresImport
=== CONT  TestAccAzureRMApiManagement_requiresImport
--- PASS: TestAccAzureRMApiManagement_requiresImport (2117.30s)
=== RUN   TestAccAzureRMApiManagement_customProps
=== PAUSE TestAccAzureRMApiManagement_customProps
=== CONT  TestAccAzureRMApiManagement_customProps
--- PASS: TestAccAzureRMApiManagement_customProps (2006.74s)
=== RUN   TestAccAzureRMApiManagement_signInSignUpSettings
=== PAUSE TestAccAzureRMApiManagement_signInSignUpSettings
=== CONT  TestAccAzureRMApiManagement_signInSignUpSettings
--- PASS: TestAccAzureRMApiManagement_signInSignUpSettings (2479.38s)
=== RUN   TestAccAzureRMApiManagement_policy
=== PAUSE TestAccAzureRMApiManagement_policy
=== CONT  TestAccAzureRMApiManagement_policy
--- PASS: TestAccAzureRMApiManagement_policy (2197.78s)
=== RUN   TestAccAzureRMApiManagement_consumption
=== PAUSE TestAccAzureRMApiManagement_consumption
=== CONT  TestAccAzureRMApiManagement_consumption
--- PASS: TestAccAzureRMApiManagement_consumption (182.58s)
=== RUN   TestAccAzureRMApiManagement_identityUserAssigned
=== PAUSE TestAccAzureRMApiManagement_identityUserAssigned
=== CONT  TestAccAzureRMApiManagement_identityUserAssigned
--- PASS: TestAccAzureRMApiManagement_identityUserAssigned (2127.51s)

yupwei68 · 2020-05-27T03:33:11Z

@tombuildsstuff corresponding changes have been made. Please continue reviewing.

sschmeck · 2020-06-03T05:58:58Z

Hi @katbyte, is your finding regarding the SDK constant waiting for another integration? :)

MireilleMedhat · 2020-06-27T21:25:01Z

Hello, can somebody please provide updates for this PR? is it planned to be merged any time soon?
Thank you:)

sschmeck · 2020-09-01T06:55:58Z

The integration is blocked until #7603 is merged, which waits for the v14.2.1 release of Azure/go-autorest.

jbrailsford · 2020-09-22T11:17:33Z

@sschmeck I believe the dependent change in go-autorest Azure/go-autorest#540 has been merged now, as such, could we prgoress this? I'm hitting my head against #6730 (comment) :(

yupwei68 · 2020-09-23T01:50:50Z

@AviateX14 What we depends on is the go-autorest from tombuildstuff' repo, which currently is blocked by go-sdk, as he says. And go-sdk is blocked by some problems released by some service teams. But now we're approaching to the release of these two. I believe I'll start on this PR soon.

sven-hoffmann · 2020-10-05T08:16:45Z

Any news here?

yupwei68 · 2020-11-26T07:31:59Z

I've merged the upstream master branch.
All tests have passed.
New test:
=== RUN TestAccAzureRMApiManagement_consumption
=== PAUSE TestAccAzureRMApiManagement_consumption
=== CONT TestAccAzureRMApiManagement_consumption
--- PASS: TestAccAzureRMApiManagement_consumption (183.75s)

katbyte

Thanks @yupwei68 - LGTM 👍

katbyte · 2020-12-11T17:42:04Z

@yupwei68 - tests have passed so this is good to merge one the conflicts are resolved

yupwei68 · 2020-12-14T03:00:59Z

Thanks @katbyte . I've merged the latest change. Please continue your review.

ghost · 2021-01-08T05:26:10Z

This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.42.0"
}
# ... other configuration ...

ghost · 2021-01-20T14:50:06Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

ghost added the size/M label May 12, 2020

yupwei68 force-pushed the wyp-6730 branch from bc395b1 to 0aefef1 Compare May 12, 2020 07:19

manicminer added service/api-management bug labels May 12, 2020

mbfrahry requested changes May 12, 2020

View reviewed changes

yupwei68 requested a review from mbfrahry May 13, 2020 01:46

katbyte added the waiting-response label May 14, 2020

katbyte reviewed May 14, 2020

View reviewed changes

azurerm/internal/services/apimanagement/validate/api_management_test.go Outdated Show resolved Hide resolved

katbyte reviewed May 14, 2020

View reviewed changes

azurerm/internal/services/apimanagement/validate/api_management_test.go Show resolved Hide resolved

katbyte reviewed May 14, 2020

View reviewed changes

azurerm/internal/services/apimanagement/validate/api_management_test.go Show resolved Hide resolved

katbyte requested changes May 14, 2020

View reviewed changes

ghost added size/XL and removed size/M labels May 14, 2020

ghost removed the waiting-response label May 14, 2020

yupwei68 requested a review from katbyte May 14, 2020 06:18

tombuildsstuff suggested changes May 14, 2020

View reviewed changes

tombuildsstuff added the waiting-response label May 14, 2020

yupwei68 requested a review from tombuildsstuff May 15, 2020 02:28

ghost removed the waiting-response label May 18, 2020

tombuildsstuff added the waiting-response label May 26, 2020

ghost removed the waiting-response label May 27, 2020

yupwei68 added 2 commits July 28, 2020 09:58

update

f3a1597

test pass

e646f58

yupwei68 added 3 commits July 28, 2020 10:04

remove case ignored

e094a58

r2

dd39c1e

fmt

b9524e3

katbyte added the waiting-response label Oct 2, 2020

ghost removed the waiting-response label Oct 5, 2020

merge

36277f6

yupwei68 changed the title ~~azurerm_api_management validate sku_name~~ azurerm_api_management add sku_name Consumption_0 Nov 26, 2020

yupwei68 force-pushed the wyp-6730 branch from d97557c to 36277f6 Compare November 26, 2020 06:00

ghost added size/L and removed size/XL labels Nov 26, 2020

update

34f8ff7

katbyte approved these changes Dec 11, 2020

View reviewed changes

yupwei68 added 3 commits December 14, 2020 09:54

merge

0f16d02

fmt

80c493b

fmt

3452bfc

yupwei68 requested a review from katbyte December 14, 2020 02:58

WodansSon added this to the v2.42.0 milestone Dec 21, 2020

WodansSon merged commit e8f41ac into hashicorp:master Dec 21, 2020

WodansSon added a commit that referenced this pull request Dec 21, 2020

Updating to include #6868

b45e80f

ghost locked as resolved and limited conversation to collaborators Jan 20, 2021

yupwei68 deleted the wyp-6730 branch June 7, 2021 06:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_api_management` add `sku_name` `Consumption_0` #6868

`azurerm_api_management` add `sku_name` `Consumption_0` #6868

yupwei68 commented May 12, 2020

mbfrahry left a comment

yupwei68 commented May 13, 2020

mbfrahry commented May 13, 2020

katbyte left a comment

yupwei68 commented May 14, 2020

tombuildsstuff left a comment

yupwei68 commented May 18, 2020

yupwei68 commented May 27, 2020

sschmeck commented Jun 3, 2020

MireilleMedhat commented Jun 27, 2020

sschmeck commented Sep 1, 2020

jbrailsford commented Sep 22, 2020

yupwei68 commented Sep 23, 2020

sven-hoffmann commented Oct 5, 2020

yupwei68 commented Nov 26, 2020

katbyte left a comment

katbyte commented Dec 11, 2020

yupwei68 commented Dec 14, 2020

ghost commented Jan 8, 2021

ghost commented Jan 20, 2021

azurerm_api_management add sku_name Consumption_0 #6868

azurerm_api_management add sku_name Consumption_0 #6868

Conversation

yupwei68 commented May 12, 2020

mbfrahry left a comment

Choose a reason for hiding this comment

yupwei68 commented May 13, 2020

mbfrahry commented May 13, 2020

katbyte left a comment

Choose a reason for hiding this comment

yupwei68 commented May 14, 2020

tombuildsstuff left a comment

Choose a reason for hiding this comment

yupwei68 commented May 18, 2020

yupwei68 commented May 27, 2020

sschmeck commented Jun 3, 2020

MireilleMedhat commented Jun 27, 2020

sschmeck commented Sep 1, 2020

jbrailsford commented Sep 22, 2020

yupwei68 commented Sep 23, 2020

sven-hoffmann commented Oct 5, 2020

yupwei68 commented Nov 26, 2020

katbyte left a comment

Choose a reason for hiding this comment

katbyte commented Dec 11, 2020

yupwei68 commented Dec 14, 2020

ghost commented Jan 8, 2021

ghost commented Jan 20, 2021

`azurerm_api_management` add `sku_name` `Consumption_0` #6868

`azurerm_api_management` add `sku_name` `Consumption_0` #6868