azurerm_storage_account - add support for static website

[aqche]

Fixes: #1903

Adds support for static web hosting to azurerm_storage_account.

=== RUN   TestAccAzureRMStorageAccount_blobAccountProperties
=== PAUSE TestAccAzureRMStorageAccount_blobAccountProperties
=== CONT  TestAccAzureRMStorageAccount_blobAccountProperties
--- PASS: TestAccAzureRMStorageAccount_blobAccountProperties (149.02s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/storage/tests       149.069s

[StefanSchoof]

Why here a path postfix? In the azure cli it is 404-document and index-document. See https://docs.microsoft.com/de-de/azure/storage/blobs/storage-blob-static-website-how-to?tabs=azure-cli

[aqche]

I named these arguments based on the names from giovanni.

It's also worth noting in Azure PowerShell, the input is called ErrorDocument404Path as well.

Any thoughts/preference from maintainers?

[tombuildsstuff]

The Azure CLI tends to stray from the Azure API/Portal quite a bit to make the commands shorter - so I wouldn't use it as the source of truth here.

That said - I'd agree about making these consistent - perhaps that'd make the most sense as index_document and error_404_document (to allow for other errorcodes in the future)?

[tombuildsstuff]

hey @aqche

Thanks for this PR - I've taken a look through and left some comments inline but this is looking fairly good to me 👍

Thanks!

[tombuildsstuff]

The Azure CLI tends to stray from the Azure API/Portal quite a bit to make the commands shorter - so I wouldn't use it as the source of truth here.

That said - I'd agree about making these consistent - perhaps that'd make the most sense as index_document and error_404_document (to allow for other errorcodes in the future)?

[aqche]

@tombuildsstuff thanks for the review, updated the code with your suggestions! Let me know what you think.

--- PASS: TestAccAzureRMStorageAccount_staticWebsiteProperties (148.88s)

[aqche]

Fixed up the tflint errors, looks like website-lint is failing from something unrelated to this PR.

edit: fixed after merging master in

[tombuildsstuff]

hey @aqche

Thanks for pushing those changes / apologies for the delayed re-review here.

I've taken a look through and besides one minor thing this otherwise LGTM 👍

Thanks!

[tombuildsstuff]

Ignoring some known test failures (which'll be fixed via #5710) - the tests look good 👍

[ghost]

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!