Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_automation_credential - deprecate account_name in favour of automation_account_name #4777

Conversation

draggeta
Copy link
Contributor

This MR does the following:

  • Add validation for automation account names, runbooks and schedules
  • Adds the automation_account_name parameter to azurerm_automation_credential
  • Updates test and docs for azurerm_automation_credential

Closes #4776

@draggeta draggeta changed the title Add input validation to automation resources and change account name parameter WIP: Add input validation to automation resources and change account name parameter Oct 31, 2019
@draggeta draggeta changed the title WIP: Add input validation to automation resources and change account name parameter Add input validation to automation resources and change account name parameter Oct 31, 2019
@draggeta
Copy link
Contributor Author

If this is accepted, the depreciation notice should probably be added to the 2.0 depreciation list?

@katbyte
Copy link
Collaborator

katbyte commented Oct 31, 2019

@draggeta, yep! it sure should be

@ghost ghost added size/L and removed size/M labels Oct 31, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @draggeta,

Overall this looks great, i've left a couple comments inline that once addressed this'll be good to merge 🙂

azurerm/resource_arm_automation_credential.go Outdated Show resolved Hide resolved
azurerm/resource_arm_automation_credential.go Outdated Show resolved Hide resolved
@katbyte katbyte added this to the v1.37.0 milestone Nov 1, 2019
@draggeta draggeta requested a review from katbyte November 1, 2019 22:58
@katbyte katbyte changed the title Add input validation to automation resources and change account name parameter azurerm_automation_credential - deprecate account_name in favour of automation_account_name Nov 3, 2019
@katbyte katbyte merged commit e3d9359 into hashicorp:master Nov 3, 2019
@katbyte
Copy link
Collaborator

katbyte commented Nov 3, 2019

whoops somehow merged before approved, LGTM now @draggeta! thanks!

katbyte added a commit that referenced this pull request Nov 3, 2019
@draggeta draggeta deleted the Add-input-validation-to-automation-resources-and-change-account_name-parameter branch November 3, 2019 21:08
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost ghost removed the waiting-response label Nov 26, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add input validation to automation resources and change account_name parameter
3 participants