Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: caching all of the account information #4709

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

tombuildsstuff
Copy link
Contributor

This PR introduces more extensive caching for Storage Accounts - which allows us to work around a low rate limit due to an unperforment API; which should improve the performance when provisioning large quantities of storage related resources

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff changed the title [WIP] storage: caching all of the account information storage: caching all of the account information Oct 28, 2019
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2019-10-28 at 17 55 52

@tombuildsstuff tombuildsstuff merged commit 33174e7 into master Oct 28, 2019
@tombuildsstuff tombuildsstuff deleted the f/storage-caching branch October 28, 2019 16:56
tombuildsstuff added a commit that referenced this pull request Oct 28, 2019
@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 28, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants