New Resource: azurerm_storage_management_policy

[stuartleeks]

Add support for Storage Management Policies to archive/delete blobs

Fixes #3316

[BenDutton]

Looks like the issue has been fixed and released :)

[sgiacomel]

Any update on this?

[stuartleeks]

I've just rebased these changes to resolve a conflict in provider.go. Let me know if you're happy to merge or have any other feedback. Thanks :-)

[batizar]

Any updates on this? Thanks.

[stuartleeks]

@batizar I'm waiting on review to see if there are any other changes required for merging. When I spoke with @tombuildsstuff he was expecting to look at this next week

[batizar]

Thanks @stuartleeks

[mbfrahry]

Hey @stuartleeks these changes look good but there are some areas where we could make improvements. The bulk of changes to make are just nil checks. Any time we are casting from an interface{} we should confirm that it's not nil. If it is nil and we try to cast it, Terraform crashes and then people could lose state so we need to limit it wherever we can. I called it out in a few places but just comb through and make sure that we're doing those checks everywhere. The other things I pointed out are just best practices we should consider adding to this PR.

[stuartleeks]

@mbfrahry - thanks for your thorough review. I've been through your review comments and believe that I have now addressed them. I've also rebased to handle conflicts with other merged changes. Let me know if there are any further changes you would like to see before merging.

[mbfrahry]

Awesome! Thanks for going through and addressing all my concerns @stuartleeks. These all look good and we're good to merge.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!