-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix test case, examples and support more event source #10126
fix test case, examples and support more event source #10126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @njuCZ
Thanks for this PR - taking a look through if we can add these new values to the documentation then this otherwise LGTM 👍
Thanks!
string(security.Assessments), | ||
string(security.SecureScoreControls), | ||
string(security.SecureScores), | ||
string(security.SubAssessments), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we update the documentation to include these new values? this should also likely be case-sensitive (by changing the true
below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for missing. Have done it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Tests look ok 👍 |
This has been released in version 2.43.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.43.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
fix #9975
doc: https://docs.microsoft.com/en-us/azure/security-center/continuous-export?tabs=azure-portal
from the portal, data export to eventhub resource depends on eventhub, and eventhub authorization rule. The original example is not right, though the original acctest could success...