-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/monitor_diagnostic_setting: handling a difference in casing the EHNamespace Authorization Rule #10104
r/monitor_diagnostic_setting: handling a difference in casing the EHNamespace Authorization Rule #10104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @andrey-dubnik
Thanks for this PR - taking a look through whilst this does solve the issue by manipulating the ID, we should be able to use a segment insensitive parser here during rewriting by generating that instead - as such if we can update this to use that then this otherwise LGTM 👍
Thanks!
azurerm/internal/services/monitor/monitor_diagnostic_setting_resource.go
Outdated
Show resolved
Hide resolved
…esource.go Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for pushing those changes @andrey-dubnik 👍
@tombuildsstuff I've also changed a code gen as otherwise generated code was failing on lint during the CI tests. All passes now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Tests look good 👍 |
This has been released in version 2.43.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.43.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Handle Azure read response with AuthorizationRules (legacy) and authorizationRules
#10097