azurerm_cosmosdb_account: enable_analytical_storage

[favoretti]

Initial implementation assumed it's a capability, whereas it's a
property. This PR implements it properly.

Fixes #9119

[favoretti]

$ TF_ACC=1 go test -v ./azurerm/internal/services/cosmos -timeout=600m -run TestAccAzureRMCosmosDBAccount_analytical_storage_enabled
=== RUN   TestAccAzureRMCosmosDBAccount_analytical_storage_enabled
=== PAUSE TestAccAzureRMCosmosDBAccount_analytical_storage_enabled
=== CONT  TestAccAzureRMCosmosDBAccount_analytical_storage_enabled
--- PASS: TestAccAzureRMCosmosDBAccount_analytical_storage_enabled (703.28s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/cosmos	705.447s

[favoretti]

Also verified during the acceptance test that account had property set properly.

[katbyte]

Thanks @favoretti - overall looks good aside from one comment

[favoretti]

$ TF_ACC=1 go test -v ./azurerm/internal/services/cosmos -timeout=600m -run TestAccCosmosDBAccount_analyticalStorage
=== RUN   TestAccCosmosDBAccount_analyticalStorage
=== PAUSE TestAccCosmosDBAccount_analyticalStorage
=== CONT  TestAccCosmosDBAccount_analyticalStorage
--- PASS: TestAccCosmosDBAccount_analyticalStorage (699.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/cosmos	700.600s

[favoretti]

@katbyte should be good to go now.

[T1loc]

@favoretti @katbyte Do you think it will be a good idea to also add the Analytical Storage Time to Live ?

[favoretti]

Sure, although I won’t be able to get to it until Monday. If you wanna do it - I’d wait for this to be merged. Conflict resolution is painful :)

…

On Thu, 7 Jan 2021 at 16:11, Florian Leparoux ***@***.***> wrote: @favoretti <https://github.com/favoretti> @katbyte <https://github.com/katbyte> Do you think it will be a good idea to also add the Analytical Storage Time to Live ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10055 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGERNTQN3LDNEQMKXHLB7TSYXFLTANCNFSM4VVOFYRA> .

[favoretti]

Reminder to myself - rename enable_analytical_storage to analytical_storage_enabled.

[tombuildsstuff]

LGTM 👍

[favoretti]

@katbyte Renamed property as requested.

[favoretti]

@T1loc Quick googling didn't tell me anything on TTL, would you be so kind to point me to it, or better yet, log a separate issue for that property, I can tackle it in a separate PR then.

[T1loc]

@T1loc Quick googling didn't tell me anything on TTL, would you be so kind to point me to it, or better yet, log a separate issue for that property, I can tackle it in a separate PR then.

@T1loc Quick googling didn't tell me anything on TTL, would you be so kind to point me to it, or better yet, log a separate issue for that property, I can tackle it in a separate PR then.

@favoretti Yes we need a new issue.
Some info about it : https://docs.microsoft.com/en-us/azure/cosmos-db/analytical-store-introduction#analytical-ttl

This options need at container creation time to have the AnalyticalStore enable. I will open an issue in ~1h

[katbyte]

@favoretti - i'm getting this test failure:

------- Stdout: -------
=== RUN   TestAccCosmosDBAccount_analyticalStorage
=== PAUSE TestAccCosmosDBAccount_analyticalStorage
=== CONT  TestAccCosmosDBAccount_analyticalStorage
    testing.go:684: Step 0 error: Check failed: 1 error occurred:
        	* Check 2/2 error: azurerm_cosmosdb_account.test: Attribute 'enable_analytical_storage' not found
        
        
--- FAIL: TestAccCosmosDBAccount_analyticalStorage (681.00s)
FAIL

[favoretti]

@tombuildsstuff Fixed acceptance test too after the rename, so maybe this can go in 2.43 too.

$ TF_ACC=1 go test -v ./azurerm/internal/services/cosmos -timeout=1000m -run TestAccCosmosDBAccount_analyticalStorage
=== RUN   TestAccCosmosDBAccount_analyticalStorage
=== PAUSE TestAccCosmosDBAccount_analyticalStorage
=== CONT  TestAccCosmosDBAccount_analyticalStorage
--- PASS: TestAccCosmosDBAccount_analyticalStorage (689.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/cosmos	690.502s

[jackofallops]

Tests are looking good now 👍

addressed

[ghost]

This has been released in version 2.43.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.43.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!