Add glue CSV classifier

[ThomasWunderlich]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #9083

Release note for CHANGELOG:

Add glue CSV Classifier  for aws_glue_classifier

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueClassifier'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSGlueClassifier -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSGlueClassifier_CsvClassifier
=== PAUSE TestAccAWSGlueClassifier_CsvClassifier
=== RUN   TestAccAWSGlueClassifier_GrokClassifier
=== PAUSE TestAccAWSGlueClassifier_GrokClassifier
=== RUN   TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns
=== PAUSE TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns
=== RUN   TestAccAWSGlueClassifier_JsonClassifier
=== PAUSE TestAccAWSGlueClassifier_JsonClassifier
=== RUN   TestAccAWSGlueClassifier_TypeChange
=== PAUSE TestAccAWSGlueClassifier_TypeChange
=== RUN   TestAccAWSGlueClassifier_XmlClassifier
=== PAUSE TestAccAWSGlueClassifier_XmlClassifier
=== CONT  TestAccAWSGlueClassifier_CsvClassifier
=== CONT  TestAccAWSGlueClassifier_TypeChange
=== CONT  TestAccAWSGlueClassifier_XmlClassifier
=== CONT  TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns
=== CONT  TestAccAWSGlueClassifier_GrokClassifier
=== CONT  TestAccAWSGlueClassifier_JsonClassifier
--- PASS: TestAccAWSGlueClassifier_GrokClassifier (22.67s)
--- PASS: TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns (22.97s)
--- PASS: TestAccAWSGlueClassifier_CsvClassifier (22.98s)
--- PASS: TestAccAWSGlueClassifier_XmlClassifier (23.06s)
--- PASS: TestAccAWSGlueClassifier_JsonClassifier (23.13s)
--- PASS: TestAccAWSGlueClassifier_TypeChange (42.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	42.606s

...

[ThomasWunderlich]

So I think this should be ready to review. The one thing is that the pull request updates/pr-filter-sync keeps being cancelled, possibly because of a timeout. I'm not sure if there's something I can do to fix that or if it's something that's just failing at the moment.

[aeschright]

It's fine to ignore that pr-filter-sync check, we're using the newer GitHub actions setup on master but it doesn't matter for existing PR branches. If you rebase on master, that might fix it.

Can you add the results of your test run in the description above? We need that before we can review this.

[ThomasWunderlich]

Thanks @aeschright! This should be ready to review now.

[vertexclique]

Any ETA for a merge window for this one?

[banspaugh]

We really need CSV classifier support, when will this be implemented?

[bflad]

Thanks so much for submitting this, @ThomasWunderlich, LGTM 🚀

--- PASS: TestAccAWSGlueClassifier_JsonClassifier (14.85s)
--- PASS: TestAccAWSGlueClassifier_XmlClassifier (15.10s)
--- PASS: TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns (15.96s)
--- PASS: TestAccAWSGlueClassifier_CsvClassifier (17.10s)
--- PASS: TestAccAWSGlueClassifier_GrokClassifier (17.55s)
--- PASS: TestAccAWSGlueClassifier_TypeChange (25.89s)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!