Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_ec2_client_vpn_endpoint: Add support for split_tunnel #9566

Merged
merged 2 commits into from
Jul 31, 2019
Merged

r/aws_ec2_client_vpn_endpoint: Add support for split_tunnel #9566

merged 2 commits into from
Jul 31, 2019

Conversation

razaj92
Copy link
Contributor

@razaj92 razaj92 commented Jul 31, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #9494

Release note for CHANGELOG:

resource/aws_ec2_client_vpn_endpoint: Add support for split_tunnel

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsEc2ClientVpnEndpoint'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAwsEc2ClientVpnEndpoint -timeout 120m
=== RUN   TestAccAwsEc2ClientVpnEndpoint_basic
=== PAUSE TestAccAwsEc2ClientVpnEndpoint_basic
=== RUN   TestAccAwsEc2ClientVpnEndpoint_msAD
=== PAUSE TestAccAwsEc2ClientVpnEndpoint_msAD
=== RUN   TestAccAwsEc2ClientVpnEndpoint_withLogGroup
=== PAUSE TestAccAwsEc2ClientVpnEndpoint_withLogGroup
=== RUN   TestAccAwsEc2ClientVpnEndpoint_withDNSServers
=== PAUSE TestAccAwsEc2ClientVpnEndpoint_withDNSServers
=== RUN   TestAccAwsEc2ClientVpnEndpoint_tags
=== PAUSE TestAccAwsEc2ClientVpnEndpoint_tags
=== CONT  TestAccAwsEc2ClientVpnEndpoint_basic
=== CONT  TestAccAwsEc2ClientVpnEndpoint_withDNSServers
=== CONT  TestAccAwsEc2ClientVpnEndpoint_tags
=== CONT  TestAccAwsEc2ClientVpnEndpoint_withLogGroup
=== CONT  TestAccAwsEc2ClientVpnEndpoint_msAD
--- PASS: TestAccAwsEc2ClientVpnEndpoint_basic (34.61s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_withDNSServers (54.38s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_withLogGroup (59.34s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_tags (75.47s)
^[[B--- PASS: TestAccAwsEc2ClientVpnEndpoint_msAD (1763.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1764.014s

@razaj92 razaj92 requested a review from a team July 31, 2019 12:45
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 31, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 31, 2019
bflad
bflad suggested changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @razaj92 👋 Thank you for this contribution! Just one minor testing note below and we can get this in. Please reach out if you have any questions or do not have time to implement the change. 😄

website/docs/r/ec2_client_vpn_endpoint.html.markdown Show resolved Hide resolved
aws/resource_aws_ec2_client_vpn_endpoint_test.go Outdated Show resolved Hide resolved
@bflad bflad self-assigned this Jul 31, 2019
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jul 31, 2019
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/codebuild Issues and PRs that pertain to the codebuild service. and removed size/XS Managed by automation to categorize the size of a PR. labels Jul 31, 2019
@razaj92
Copy link
Contributor Author

razaj92 commented Jul 31, 2019

Hi @bflad 👋

Thanks for the comments, I've pushed the changes as requested

Let me know if theres anything else 🙂

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jul 31, 2019
@bflad bflad self-requested a review July 31, 2019 19:47
@bflad bflad added this to the v2.22.0 milestone Jul 31, 2019
bflad
bflad approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks, @razaj92! 🚀

--- PASS: TestAccAwsEc2ClientVpnEndpoint_splitTunnel (16.63s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_withLogGroup (17.04s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_basic (17.42s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_withDNSServers (20.85s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_tags (23.78s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_msAD (1724.26s)

@bflad bflad merged commit aa7d53b into hashicorp:master Jul 31, 2019
bflad added a commit that referenced this pull request Jul 31, 2019
@bflad
Update CHANGELOG for #9566
674f7bb
@ghost
Copy link

ghost commented Aug 1, 2019

This has been released in version 2.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.22.0
Development

Successfully merging this pull request may close these issues.

r/aws_ec2_client_vpn_endpoint: support split-tunnel
2 participants
@razaj92 @bflad