Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_db_event_subscription: Handle SubscriptionNotFound errors during Read and Deletion #9371

Merged
merged 1 commit into from
Jul 18, 2019
Merged

resource/aws_db_event_subscription: Handle SubscriptionNotFound errors during Read and Deletion #9371

merged 1 commit into from
Jul 18, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 16, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9368

Release note for CHANGELOG:

* resource/aws_db_event_subscription: Handle `SubscriptionNotFound` errors during refresh and deletion

Previously (in us-gov-west-1 and us-east-1):

--- FAIL: TestAccAWSDBEventSubscription_basicUpdate (1228.44s)
    testing.go:629: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

        Error: errors during apply: error waiting for RDS Event Subscription (tf-acc-test-rds-event-subs-2201031712637090321) deletion: SubscriptionNotFound: Event Subscription tf-acc-test-rds-event-subs-2201031712637090321 not found.

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSDBEventSubscription_withPrefix (535.76s)
--- PASS: TestAccAWSDBEventSubscription_importBasic (537.39s)
--- PASS: TestAccAWSDBEventSubscription_withSourceIds (539.77s)
--- PASS: TestAccAWSDBEventSubscription_disappears (543.52s)
--- PASS: TestAccAWSDBEventSubscription_categoryUpdate (944.42s)
--- PASS: TestAccAWSDBEventSubscription_basicUpdate (945.75s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSDBEventSubscription_withPrefix (622.68s)
--- PASS: TestAccAWSDBEventSubscription_importBasic (623.98s)
--- PASS: TestAccAWSDBEventSubscription_withSourceIds (628.56s)
--- PASS: TestAccAWSDBEventSubscription_disappears (631.20s)
--- PASS: TestAccAWSDBEventSubscription_basicUpdate (978.81s)
--- PASS: TestAccAWSDBEventSubscription_categoryUpdate (978.91s)

@bflad
resource/aws_db_event_subscription: Handle SubscriptionNotFound error…
6977e9e 
…s during Read and Deletion

Reference: #9368

Previously (in us-gov-west-1 and us-east-1):

```
--- FAIL: TestAccAWSDBEventSubscription_basicUpdate (1228.44s)
    testing.go:629: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

        Error: errors during apply: error waiting for RDS Event Subscription (tf-acc-test-rds-event-subs-2201031712637090321) deletion: SubscriptionNotFound: Event Subscription tf-acc-test-rds-event-subs-2201031712637090321 not found.
```

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSDBEventSubscription_withPrefix (535.76s)
--- PASS: TestAccAWSDBEventSubscription_importBasic (537.39s)
--- PASS: TestAccAWSDBEventSubscription_withSourceIds (539.77s)
--- PASS: TestAccAWSDBEventSubscription_disappears (543.52s)
--- PASS: TestAccAWSDBEventSubscription_categoryUpdate (944.42s)
--- PASS: TestAccAWSDBEventSubscription_basicUpdate (945.75s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSDBEventSubscription_withPrefix (622.68s)
--- PASS: TestAccAWSDBEventSubscription_importBasic (623.98s)
--- PASS: TestAccAWSDBEventSubscription_withSourceIds (628.56s)
--- PASS: TestAccAWSDBEventSubscription_disappears (631.20s)
--- PASS: TestAccAWSDBEventSubscription_basicUpdate (978.81s)
--- PASS: TestAccAWSDBEventSubscription_categoryUpdate (978.91s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. labels Jul 16, 2019
@bflad bflad requested a review from a team July 16, 2019 21:49
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Jul 16, 2019
@bflad bflad mentioned this pull request Jul 16, 2019
Closed
@bflad bflad added this to the v2.20.0 milestone Jul 17, 2019
nywilken
nywilken approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

I confirmed the failures on master, and validated that this fix addresses the issue within the specified cases. I tried a few other regions in Asia but they don't seem to have this issue.

@bflad bflad merged commit 0959f39 into master Jul 18, 2019
@bflad bflad deleted the b-aws_db_event_subscription-SubscriptionNotFound branch July 18, 2019 14:00
bflad added a commit that referenced this pull request Jul 18, 2019
@bflad
Update CHANGELOG for #9371
c17c426
@nywilken
Copy link
Contributor

The fix to the aws_db_event_subscription resource, has been released in version 2.20.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this resource, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.20.0
Development

Successfully merging this pull request may close these issues.

issue dropping a rds event subscription
2 participants
@bflad @nywilken