Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Sources: aws_servicequotas_service and aws_servicequotas_service_quota #9177

Merged
merged 4 commits into from
Jul 1, 2019
Merged

New Data Sources: aws_servicequotas_service and aws_servicequotas_service_quota #9177

merged 4 commits into from
Jul 1, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 28, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9122

Release note for CHANGELOG:

* **New Data Source:** `aws_servicequotas_service`
* **New Data Source:** `aws_servicequotas_service_quota`

Output from acceptance testing:

--- PASS: TestAccAwsServiceQuotasServiceDataSource_ServiceName (15.13s)

--- PASS: TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaCode (9.93s)
--- PASS: TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaName (10.11s)

@bflad
New Data Source: aws_servicequotas_service
7753799 
Reference: #9122

Output from acceptance testing:

```
--- PASS: TestAccAwsServiceQuotasServiceDataSource_ServiceName (15.13s)
```
@bflad
New Data Source: aws_servicequotas_service_quota
8778630 
Reference: #9122

Output from acceptance testing:

```
--- PASS: TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaCode (9.93s)
--- PASS: TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaName (10.11s)
```
@bflad bflad added new-data-source Introduces a new data source. service/servicequotas Issues and PRs that pertain to the servicequotas service. labels Jun 28, 2019
@bflad bflad requested a review from a team June 28, 2019 03:21
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 28, 2019
@bflad bflad mentioned this pull request Jun 28, 2019
Closed
@bflad
data-source/aws_servicequotas_service: go fmt
b84a32d
@bflad
data-source/aws_servicequotas_service_quota: Add default_value attribute
c1f11ab 
Output from acceptance testing:

```
--- PASS: TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaCode (10.98s)
--- PASS: TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaName (10.98s)
```
@bflad bflad mentioned this pull request Jun 28, 2019
Closed
aeschright
aeschright approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bflad bflad added this to the v2.18.0 milestone Jul 1, 2019
@bflad bflad merged commit 4fc6d53 into master Jul 1, 2019
@bflad bflad deleted the f-servicequotas-data-sources branch July 1, 2019 18:09
bflad added a commit that referenced this pull request Jul 1, 2019
@bflad
Update CHANGELOG for #9177
cda113f
@bflad
Copy link
Contributor Author

bflad commented Jul 5, 2019

This has been released in version 2.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aeschright aeschright aeschright approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/servicequotas Issues and PRs that pertain to the servicequotas service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.18.0
Development

Successfully merging this pull request may close these issues.

Support Data Sources for Service Quotas
2 participants
@bflad @aeschright