Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/batch_compute_environment: Support LaunchTemplate #8026

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

atsushi-ishibashi
Copy link
Contributor

@atsushi-ishibashi atsushi-ishibashi commented Mar 20, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #6454

Changes proposed in this pull request:

  • aws_batch_compute_environment supports LaunchTemplate

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSBatchComputeEnvironment_launchTemplate'
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSBatchComputeEnvironment_launchTemplate -timeout 120m
=== RUN   TestAccAWSBatchComputeEnvironment_launchTemplate
=== PAUSE TestAccAWSBatchComputeEnvironment_launchTemplate
=== CONT  TestAccAWSBatchComputeEnvironment_launchTemplate
--- PASS: TestAccAWSBatchComputeEnvironment_launchTemplate (82.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	82.120s

@ghost ghost added documentation Introduces or discusses updates to documentation. service/batch Issues and PRs that pertain to the batch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Mar 20, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 20, 2019
@bflad bflad added this to the v2.4.0 milestone Mar 29, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @atsushi-ishibashi! 🚀

--- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources (19.13s)
--- PASS: TestAccAWSBatchComputeEnvironment_createSpotWithoutBidPercentage (25.19s)
--- PASS: TestAccAWSBatchComputeEnvironment_createUnmanaged (44.90s)
--- PASS: TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources (45.91s)
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2 (47.56s)
--- PASS: TestAccAWSBatchComputeEnvironment_launchTemplate (51.78s)
--- PASS: TestAccAWSBatchComputeEnvironment_createSpot (57.20s)
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithTags (57.25s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateState (67.07s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateMaxvCpus (78.02s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateComputeEnvironmentName (85.88s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateInstanceType (97.29s)

@bflad bflad merged commit 6c42951 into hashicorp:master Mar 29, 2019
bflad added a commit that referenced this pull request Mar 29, 2019
@bflad
Copy link
Contributor

bflad commented Mar 29, 2019

This has been released in version 2.4.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/batch Issues and PRs that pertain to the batch service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for EC2 Launch Templates to Batch
2 participants