Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-source/aws_instance: Add get_user_data argument and user_data_base64 attribute #8001

Merged
merged 2 commits into from
Mar 19, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 19, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #5927

As contents may be large and not necessarily safe for the Terraform state, which requires valid UTF-8, we allow retrieving the Base64 contents of EC2 Instance user data into the user_data_base64 attribute when a new get_user_data argument is set to true. The SHA-1 hash of the EC2 Instance user data will continue to be set in the user_data attribute regardless of the get_user_data argument.

Output from acceptance testing:

--- PASS: TestAccAWSInstanceDataSource_basic (149.59s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData (158.67s)

…se64 attribute

Reference: #5927

As contents may be large and not necessarily safe for the Terraform state, which requires valid UTF-8, we allow retrieving the Base64 contents of EC2 Instance user data into the `user_data_base64` attribute when a new `get_user_data` argument is set to `true`.

Output from acceptance testing:

```
--- PASS: TestAccAWSInstanceDataSource_basic (149.59s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData (158.67s)
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Mar 19, 2019
@bflad bflad requested a review from a team March 19, 2019 00:44
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 19, 2019
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one question around an additional test case for the basic configuration, but this is otherwise good to go.

…for instance without user data

```
--- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (210.42s)
```
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Mar 19, 2019
@bflad bflad added this to the v2.3.0 milestone Mar 19, 2019
@bflad bflad merged commit d759b52 into master Mar 19, 2019
@bflad bflad deleted the f-aws_instance-datasource-user_data_base64 branch March 19, 2019 18:41
bflad added a commit that referenced this pull request Mar 19, 2019
@bflad
Copy link
Contributor Author

bflad commented Mar 21, 2019

This has been released in version 2.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_instance data source should expose "user_data" content
2 participants