Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_kinesis_firehose_delivery_stream: Add extended_s3_configuration error_output_prefix argument #7026

Merged
merged 1 commit into from
Jan 5, 2019
Merged

resource/aws_kinesis_firehose_delivery_stream: Add extended_s3_configuration error_output_prefix argument #7026

merged 1 commit into from
Jan 5, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 4, 2019 •
edited
Loading

Fixes #6984

Changes proposed in this pull request:

  • resource/aws_kinesis_firehose_delivery_stream: Add extended_s3_configuration error_output_prefix argument

Output from acceptance testing:

--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3KinesisStreamSource (96.40s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_ErrorOutputPrefix (131.34s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3InvalidProcessorType (0.52s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3basic (132.34s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3InvalidParameterName (0.53s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3basic (133.52s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_ParquetSerDe_Empty (138.58s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Enabled (144.99s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Serializer_Update (146.13s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3WithCloudwatchLogging (149.34s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_OrcSerDe_Empty (150.58s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Deserializer_Update (163.00s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_HiveJsonSerDe_Empty (166.98s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3basicWithTags (168.00s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_importBasic (184.13s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_OpenXJsonSerDe_Empty (186.71s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3ConfigUpdates (230.77s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3Updates (117.66s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3KmsKeyArn (162.71s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_missingProcessingConfiguration (122.05s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_SplunkConfigUpdates (156.08s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_RedshiftConfigUpdates (689.12s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ElasticsearchConfigUpdates (1017.49s)

@bflad
resource/aws_kinesis_firehose_delivery_stream: Add extended_s3_config…
54595d5 
…uration error_output_prefix argument

Output from acceptance testing:

```
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3basic (126.04s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_ErrorOutputPrefix (218.84s)
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service. labels Jan 4, 2019
@bflad bflad requested a review from a team January 4, 2019 01:06
@ghost ghost added documentation Introduces or discusses updates to documentation. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 4, 2019
@bflad bflad mentioned this pull request Jan 4, 2019
Closed
tombuildsstuff
tombuildsstuff approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.55.0 milestone Jan 5, 2019
@bflad bflad merged commit 86ff659 into master Jan 5, 2019
@bflad bflad deleted the f-aws_kinesis_firehose_delivery_stream-error_output_prefix branch January 5, 2019 03:48
bflad added a commit that referenced this pull request Jan 5, 2019
@bflad
Update CHANGELOG for #7026
bbe521f
@bflad
Copy link
Contributor Author

bflad commented Jan 10, 2019

This has been released in version 1.55.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@mwarkentin mwarkentin mentioned this pull request Mar 15, 2019
Closed
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.55.0
Development

Successfully merging this pull request may close these issues.

In Kinesis Firehose Delivery Stream, for extended S3 destination cannot find argument ErrorOutputPrefix
2 participants
@bflad @tombuildsstuff