service/ec2: Treat empty TGW Route Table IDs when searching for associations/propagations as missing #6665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iations/propagations as missing
Previously:
```
--- FAIL: TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTableAssociationAndPropagationDisabled (87.32s)
testing.go:538: Step 0 error: Error applying: 1 error occurred:
* aws_ec2_transit_gateway_vpc_attachment.test: 1 error occurred:
* aws_ec2_transit_gateway_vpc_attachment.test: error updating EC2 Transit Gateway Attachment (tgw-attach-0e5e1795143bd2b2e) Route Table () association: error determining EC2 Transit Gateway Attachment Route Table () association (tgw-attach-0e5e1795143bd2b2e): MissingParameter: Missing required parameter in request: TransitGatewayRouteTableId.
```
Output from acceptance testing:
```
--- PASS: TestAccAWSEc2TransitGateway_AmazonSideASN (282.51s)
--- PASS: TestAccAWSEc2TransitGateway_AutoAcceptSharedAttachments (282.79s)
--- PASS: TestAccAWSEc2TransitGateway_basic (119.74s)
--- PASS: TestAccAWSEc2TransitGateway_DefaultRouteTableAssociation (304.57s)
--- PASS: TestAccAWSEc2TransitGateway_DefaultRouteTableAssociationAndPropagationDisabled (97.26s)
--- PASS: TestAccAWSEc2TransitGateway_DefaultRouteTablePropagation (292.85s)
--- PASS: TestAccAWSEc2TransitGateway_Description (303.75s)
--- PASS: TestAccAWSEc2TransitGateway_disappears (133.04s)
--- PASS: TestAccAWSEc2TransitGateway_DnsSupport (294.91s)
--- PASS: TestAccAWSEc2TransitGateway_Tags (142.00s)
--- PASS: TestAccAWSEc2TransitGateway_VpnEcmpSupport (262.29s)
--- PASS: TestAccAWSEc2TransitGatewayDataSource_Filter (149.81s)
--- PASS: TestAccAWSEc2TransitGatewayDataSource_ID (150.09s)
--- PASS: TestAccAWSEc2TransitGatewayRoute_basic (199.22s)
--- PASS: TestAccAWSEc2TransitGatewayRoute_disappears (274.00s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTable_basic (180.87s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTable_disappears (222.99s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTable_disappears_TransitGateway (151.50s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTable_Tags (207.50s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTableAssociation_basic (274.40s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTableDataSource_Filter (194.26s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTableDataSource_ID (182.70s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTablePropagation_basic (237.60s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_basic (205.70s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_disappears (210.35s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_DnsSupport (241.30s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_Ipv6Support (267.59s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_SubnetIds (370.24s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_Tags (294.68s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTableAssociation (330.97s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTableAssociationAndPropagationDisabled (212.14s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTablePropagation (275.11s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_Filter (206.94s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_ID (207.48s)
```
bflad
added
bug
ghost
added
size/M
|
This has been released in version 1.51.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
This still remains an issue. Have tried with AWS Provider versions |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6664
When creating an EC2 Transit Gateway with both flags set to disable default route table association and propagation, presumably it is no longer creating a default route table, which would cause issues downstream when determining if the VPC attachment was associated with said (now non-existent) default route table. This logic now returns that the association/propagation doesn't exist if there is not a provided route table ID to check.
Previously:
Output from acceptance testing: