Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kinesis Analytics typo #6495

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Fix Kinesis Analytics typo #6495

merged 1 commit into from
Nov 19, 2018

Conversation

gthole
Copy link
Contributor

@gthole gthole commented Nov 16, 2018

Changes proposed in this pull request:

  • Fix typo in new Kinesis Analytics Application resource

Was getting the following error:

Error: aws_kinesis_analytics_application.detection: inputs.0: invalid or unknown key: processing_configurations

Where processing_configuration (singular) is required, and the change resolves the error.

Output from acceptance testing:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSKinesisAnalyticsApplication*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSKinesisAnalyticsApplication* -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsApplication_basic
=== PAUSE TestAccAWSKinesisAnalyticsApplication_basic
=== RUN   TestAccAWSKinesisAnalyticsApplication_update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_update
=== RUN   TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== PAUSE TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== RUN   TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== PAUSE TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsAdd
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsAdd
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_referenceDataSource
=== PAUSE TestAccAWSKinesisAnalyticsApplication_referenceDataSource
=== RUN   TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== PAUSE TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== CONT  TestAccAWSKinesisAnalyticsApplication_basic
=== CONT  TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== CONT  TestAccAWSKinesisAnalyticsApplication_referenceDataSource
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsAdd
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== CONT  TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== CONT  TestAccAWSKinesisAnalyticsApplication_update
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (9.08s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_update (13.92s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSource (15.23s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions (22.49s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate (26.38s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions (27.60s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream (83.59s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream (83.67s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsAdd (87.29s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsAdd (99.56s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream (160.50s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream (160.51s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       160.547s

@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Nov 16, 2018
@bflad bflad added bug Addresses a defect in current functionality. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service. labels Nov 19, 2018
@bflad bflad added this to the v1.46.0 milestone Nov 19, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this @gthole. Hopefully in the future an acceptance test can be added to cover this as well.

@bflad bflad merged commit 2bb8ab0 into hashicorp:master Nov 19, 2018
bflad added a commit that referenced this pull request Nov 19, 2018
@bflad
Copy link
Contributor

bflad commented Nov 20, 2018

This has been released in version 1.46.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants