Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/aws_iot_endpoint: Add endpoint_type argument #6215

Merged
merged 1 commit into from
Oct 30, 2018
Merged

data-source/aws_iot_endpoint: Add endpoint_type argument #6215

merged 1 commit into from
Oct 30, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 19, 2018

Closes #6213

The old VeriSign endpoints can cause issues due to the Symantec distrust process rolling out.

Changes proposed in this pull request:

  • Add endpoint_type argument to aws_iot_endpoint data source

Output from acceptance testing:

--- PASS: TestAccAWSIotEndpointDataSource_EndpointType_IOTJobs (9.57s)
--- PASS: TestAccAWSIotEndpointDataSource_EndpointType_IOTCredentialProvider (9.64s)
--- PASS: TestAccAWSIotEndpointDataSource_basic (9.73s)
--- PASS: TestAccAWSIotEndpointDataSource_EndpointType_IOTDataATS (9.78s)
--- PASS: TestAccAWSIotEndpointDataSource_EndpointType_IOTData (9.95s)

@bflad
data-source/aws_iot_endpoint: Add endpoint_type argument
367cfc1 
```
--- PASS: TestAccAWSIotEndpointDataSource_EndpointType_IOTJobs (9.57s)
--- PASS: TestAccAWSIotEndpointDataSource_EndpointType_IOTCredentialProvider (9.64s)
--- PASS: TestAccAWSIotEndpointDataSource_basic (9.73s)
--- PASS: TestAccAWSIotEndpointDataSource_EndpointType_IOTDataATS (9.78s)
--- PASS: TestAccAWSIotEndpointDataSource_EndpointType_IOTData (9.95s)
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/iot Issues and PRs that pertain to the iot service. labels Oct 19, 2018
@bflad bflad requested a review from a team October 19, 2018 14:29
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 19, 2018
@bflad bflad mentioned this pull request Oct 19, 2018
Closed
tombuildsstuff
tombuildsstuff approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.42.0 milestone Oct 30, 2018
@bflad bflad merged commit c001418 into master Oct 30, 2018
@bflad bflad deleted the f-aws_iot_endpoint-endpoint_type branch October 30, 2018 03:59
bflad added a commit that referenced this pull request Oct 30, 2018
@bflad
Update CHANGELOG for #6215
a60e8f5
@bflad
Copy link
Contributor Author

bflad commented Nov 1, 2018

This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/iot Issues and PRs that pertain to the iot service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.42.0
Development

Successfully merging this pull request may close these issues.

Support IoT ATS endpoints and make them default
2 participants
@bflad @tombuildsstuff