Fix "random" ECS task placement strategy #6176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/M
bflad
reviewed
Oct 16, 2018
aws/resource_aws_ecs_service_test.go
Outdated
| testAccCheckAWSEcsServiceExists("aws_ecs_service.mongo", &service), | ||
| resource.TestCheckResourceAttr("aws_ecs_service.mongo", "ordered_placement_strategy.#", "1"), | ||
| resource.TestCheckResourceAttr("aws_ecs_service.mongo", "ordered_placement_strategy.0.type", "random"), | ||
| resource.TestCheckNoResourceAttr("aws_ecs_service.mongo", "ordered_placement_strategy.0.field"), |
There was a problem hiding this comment.
This seems to be failing acceptance testing at the moment:
--- FAIL: TestAccAWSEcsService_withPlacementStrategy (32.95s)
testing.go:538: Step 2 error: Check failed: Check 4/4 error: aws_ecs_service.mongo: Attribute 'ordered_placement_strategy.0.field' found when not expectedThere was a problem hiding this comment.
Whoops, my mistake. Fixed and learned how to run the acceptance tests. :)
We want Field attribute to be nil when creating the resource, but the attribute still exists when querying the resource.
bflad
approved these changes
Oct 18, 2018
There was a problem hiding this comment.
Thanks, @jnjackins! 🚀
21 tests passed (all tests)
--- PASS: TestAccAWSEcsService_disappears (7.43s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (8.49s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (8.88s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (8.89s)
--- PASS: TestAccAWSEcsService_withARN (12.02s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (12.87s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (20.96s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (17.38s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (28.04s)
--- PASS: TestAccAWSEcsService_withIamRole (28.91s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (29.91s)
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (31.08s)
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (32.50s)
--- PASS: TestAccAWSEcsService_basicImport (41.71s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (41.55s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (42.65s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (44.08s)
--- PASS: TestAccAWSEcsService_withLbChanges (132.15s)
--- PASS: TestAccAWSEcsService_withAlb (185.44s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (197.29s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (359.60s)
bflad
added a commit
that referenced
this pull request
Oct 18, 2018
|
This has been released in version 1.41.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
Excellent, thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the "random" ECS task placement strategy. Without this change, it is impossible to use this strategy. The AWS Go SDK requires the
Fieldparameter to benilwhenTypeis random, but we were sending a pointer to"".Fixes #5387