aws_dynamodb_table: Work around tagging limitation in dynamodb-local

[stefansundin]

Changes proposed in this pull request:

• Support tagging limitation in dynamodb-local.

I have yet to try more complicated things with dynamodb-local.

Here's how I use dynamodb-local:

docker run -p 8000:8000 amazon/dynamodb-local

Terraform:

provider "aws" {
  endpoints {
    dynamodb = "http://localhost:8000"
  }
}

resource "aws_dynamodb_table" "basic-dynamodb-table" {
  # ...
}

This would fail with:

* aws_dynamodb_table.basic-dynamodb-table: aws_dynamodb_table.basic-dynamodb-table: Error reading tags from dynamodb resource: UnknownOperationException: Tagging is not currently supported in DynamoDB Local.
	status code: 400, request id: d2dabf86-9643-4cc5-b601-f473573c6506
* data.aws_dynamodb_table.movies: 1 error(s) occurred:

I don't think there is a need to work around setting tags at this time. In Terraform 0.12 that can probably be easily done with the new if statement.

This problem is referenced in this issue (but also other problems): #1059

P.S. Can you please take a second look at some of my other PRs?

• aws_emr_cluster importer #4488
  • I think this can be merged now.
• r/aws_db_parameter_group, r/aws_rds_cluster_parameter_group: Support resetting parameters #5728
  • I need help with tests on this one.
• [d/aws_lambda_function] Remove default qualifier #5812
  • I know this is a breaking change, but would be nice to know if/how it can be merged.

Thank you!!

[ewbankkit]

Suggest using isAWSErr if applicable (requires knowing the value of awserr.Error.Code()).

[stefansundin]

Updated. Thanks!

[bflad]

Looks great, @stefansundin, thanks! 🚀

--- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (1.66s)
--- PASS: TestAccAWSDynamoDbTable_tags (38.77s)
--- PASS: TestAccAWSDynamoDbTable_importTimeToLive (69.31s)
--- PASS: TestAccAWSDynamoDbTable_importTags (97.33s)
--- PASS: TestAccAWSDynamoDbTable_basic (109.78s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (1.40s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (125.43s)
--- PASS: TestAccAWSDynamoDbTable_importBasic (140.33s)
--- PASS: TestAccAWSDynamoDbTable_encryption (40.15s)
--- PASS: TestAccAWSDynamoDbTable_ttl (132.50s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (204.47s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (185.93s)
--- PASS: TestAccAWSDynamoDbTable_extended (229.43s)
--- PASS: TestAccAWSDynamoDbTable_enablePitr (293.28s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdate (426.47s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (530.16s)

[stefansundin]

Thanks for the quick merge @bflad. Can you check on my other PRs that I linked above? :)

I think at least the first one can be merged, but the other two I need help on.

[bflad]

@stefansundin left a comment on #4488, I'm not sure when I'll have time to properly review #5728, and #5812 might be able to get in when all the other work associated with cutting version 2.0.0 is getting merged in.

This has been released in version 1.41.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!