Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource: aws_dx_bgp_peer #5886

Merged
merged 5 commits into from
Sep 14, 2018
Merged

New resource: aws_dx_bgp_peer #5886

merged 5 commits into from
Sep 14, 2018

Conversation

ewbankkit
Copy link
Contributor

Fixes #4961.
Acceptance tests:

$ export DX_VIRTUAL_INTERFACE_ID=dxvif-xxxxxxxx
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxBgpPeer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAwsDxBgpPeer_ -timeout 120m
=== RUN   TestAccAwsDxBgpPeer_basic
--- PASS: TestAccAwsDxBgpPeer_basic (410.30s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws    427.699s

@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Sep 14, 2018
@bflad bflad added new-resource Introduces a new resource. service/directconnect Issues and PRs that pertain to the directconnect service. labels Sep 14, 2018
bflad
bflad approved these changes Sep 14, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @ewbankkit! 🚀

@bflad bflad added this to the v1.37.0 milestone Sep 14, 2018
@bflad bflad merged commit 6acbdbb into hashicorp:master Sep 14, 2018
bflad added a commit that referenced this pull request Sep 14, 2018
@bflad
Update CHANGELOG for #5886
e7a191e
@ewbankkit ewbankkit deleted the issue-4961 branch September 15, 2018 11:27
@bflad
Copy link
Contributor

bflad commented Sep 19, 2018

This has been released in version 1.37.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@paultyng paultyng mentioned this pull request Oct 31, 2018
Merged
@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
new-resource Introduces a new resource. service/directconnect Issues and PRs that pertain to the directconnect service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.37.0
Development

Successfully merging this pull request may close these issues.

New resource: aws_dx_bgp_peer
2 participants
@ewbankkit @bflad