Suppress task definition diffs for equivalent port mappings.

[jmcarp]

When using the awsvpc networking mode, aws assigns the value of
containerPort to the hostPort for each item in portMappings. This
leads to spurious diffs if the user doesn't set hostPort. This patch
suppresses diffs when using awsvpc networking and the hostPort field
is unset.

[Fixes #3401]

$ make testacc TESTARGS='-run=TestAccAWSAvailabilityZones'
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSEcsTaskDefinition_basic
--- PASS: TestAccAWSEcsTaskDefinition_basic (10.81s)
=== RUN   TestAccAWSEcsTaskDefinition_withScratchVolume
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (5.30s)
=== RUN   TestAccAWSEcsTaskDefinition_withEcsService
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (47.95s)
=== RUN   TestAccAWSEcsTaskDefinition_withTaskRoleArn
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (8.24s)
=== RUN   TestAccAWSEcsTaskDefinition_withNetworkMode
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (6.14s)
=== RUN   TestAccAWSEcsTaskDefinition_constraint
--- PASS: TestAccAWSEcsTaskDefinition_constraint (5.36s)
=== RUN   TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
--- PASS: TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource (10.78s)
=== RUN   TestAccAWSEcsTaskDefinition_arrays
--- PASS: TestAccAWSEcsTaskDefinition_arrays (4.83s)
=== RUN   TestAccAWSEcsTaskDefinition_Fargate
--- PASS: TestAccAWSEcsTaskDefinition_Fargate (7.27s)
=== RUN   TestAccAWSEcsTaskDefinition_ExecutionRole
--- PASS: TestAccAWSEcsTaskDefinition_ExecutionRole (6.29s)
=== RUN   TestAccAWSEcsTaskDefinition_Inactive
--- PASS: TestAccAWSEcsTaskDefinition_Inactive (11.15s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       124.882s
...

[bflad]

LGTM and ignoring my testing nitpick. Thanks, @jmcarp 🚀

--- PASS: TestAccAWSEcsTaskDefinition_constraint (4.42s)
--- PASS: TestAccAWSEcsTaskDefinition_arrays (4.61s)
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (4.63s)
--- PASS: TestAccAWSEcsTaskDefinition_Inactive (7.05s)
--- PASS: TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource (7.11s)
--- PASS: TestAccAWSEcsTaskDefinition_basic (7.51s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (7.80s)
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (7.80s)
--- PASS: TestAccAWSEcsTaskDefinition_Fargate (11.02s)
--- PASS: TestAccAWSEcsTaskDefinition_ExecutionRole (12.07s)
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (42.81s)

[bflad]

Nitpick: It'd be much better if this was a separate test and test configuration as it does not pertain to the basic functionality of the resource with Fargate

[bflad]

This has been released in version 1.36.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!