Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_kinesis_firehose_delivery_stream: Support Redshift processing_configuration #4251

Merged
merged 2 commits into from
Apr 23, 2018
Merged

resource/aws_kinesis_firehose_delivery_stream: Support Redshift processing_configuration #4251

merged 2 commits into from
Apr 23, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 18, 2018 •
edited
Loading

Closes #513

Test failure is a known issue.

=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3InvalidParameterName
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3InvalidParameterName (1.53s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3InvalidProcessorType
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3InvalidProcessorType (1.95s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_missingProcessingConfiguration
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_missingProcessingConfiguration (97.07s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3KinesisStreamSource
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3KinesisStreamSource (102.50s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3Updates
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3Updates (103.84s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3basic
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3basic (107.25s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_importBasic
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_importBasic (108.98s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3basic
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3basic (109.01s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3KmsKeyArn
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3KmsKeyArn (125.83s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3ConfigUpdates
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3ConfigUpdates (183.52s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3WithCloudwatchLogging
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3WithCloudwatchLogging (229.20s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_SplunkConfigUpdates
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_SplunkConfigUpdates (262.68s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_RedshiftConfigUpdates
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_RedshiftConfigUpdates (1058.01s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ElasticsearchConfigUpdates
--- FAIL: TestAccAWSKinesisFirehoseDeliveryStream_ElasticsearchConfigUpdates (1273.59s)
    testing.go:518: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_kinesis_firehose_delivery_stream.test_stream_es: 1 error(s) occurred:
        
        * aws_kinesis_firehose_delivery_stream.test_stream_es: error creating Kinesis Firehose Delivery Stream: InvalidArgumentException: Delivery Role is not authorized to describe the Elasticsearch domain: arn:aws:es:us-west-2:*******:domain/es-test-8013883722251758873.
            status code: 400, request id: 4c708fc7-432b-11e8-9cb3-a9462fe68d6e

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service. labels Apr 18, 2018
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Apr 18, 2018
@bflad bflad mentioned this pull request Apr 18, 2018
Closed
@bflad bflad requested a review from a team April 18, 2018 18:39
@scorsi
Copy link

scorsi commented Apr 19, 2018 •
edited
Loading

Hi,
In which version will this feature be implemented ?
Thanks,

@bflad
Copy link
Contributor Author

bflad commented Apr 20, 2018

@scorsi Generally pull requests will be marked with the appropriate vX.Y.Z milestone if they are targeting a specific release. This pull request will have that information when it is reviewed by a maintainer and merged, but it is currently not targeting any specific release.

tombuildsstuff
tombuildsstuff approved these changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor 🤔 otherwise LGTM 👍

aws/resource_aws_kinesis_firehose_delivery_stream_test.go Outdated
@@ -1177,6 +1202,16 @@ resource "aws_kinesis_firehose_delivery_stream" "test_stream" {
data_table_name = "test-table"
copy_options = "GZIP"
data_table_columns = "test-col"
processing_configuration = [{
enabled = "false",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need the quotes around it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not! Thanks for catching that.

@bflad bflad added this to the v1.16.0 milestone Apr 23, 2018
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Apr 23, 2018
@bflad bflad merged commit 274035c into master Apr 23, 2018
@bflad bflad deleted the f-aws_kinesis_firehose_delivery_stream-redshift-processing_configuration branch April 23, 2018 15:06
bflad added a commit that referenced this pull request Apr 23, 2018
@bflad
Update CHANGELOG for #4251
4d2e832
@bflad
Copy link
Contributor Author

bflad commented Apr 25, 2018

This has been released in version 1.16.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

Support Kinesis Firehose Data Transformation
3 participants
@bflad @scorsi @tombuildsstuff