Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_kinesis_firehose_delivery_stream: Prevent crash on malformed ID for import #3834

Merged
merged 1 commit into from
Mar 20, 2018
Merged

resource/aws_kinesis_firehose_delivery_stream: Prevent crash on malformed ID for import #3834

merged 1 commit into from
Mar 20, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 19, 2018

Fixes #3833

Also provides a friendlier error on ARN parsing errors.

Before code change:

=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_importBasic
panic: runtime error: index out of range

After code change:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSKinesisFirehoseDeliveryStream_importBasic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSKinesisFirehoseDeliveryStream_importBasic -timeout 120m
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_importBasic
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_importBasic (118.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	118.202s

@bflad bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/firehose Issues and PRs that pertain to the firehose service. labels Mar 19, 2018
@bflad bflad added this to the v1.12.0 milestone Mar 19, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Mar 19, 2018
@bflad bflad mentioned this pull request Mar 19, 2018
Closed
radeksimko
radeksimko approved these changes Mar 20, 2018
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks-good-to-me-ship-it

@bflad bflad merged commit d6eb19e into master Mar 20, 2018
@bflad bflad deleted the b-aws_kinesis_firehose_delivery_stream-arn-import-crash branch March 20, 2018 12:50
bflad added a commit that referenced this pull request Mar 20, 2018
@bflad
Update CHANGELOG for #3834
b15ad12
@bflad
Copy link
Contributor Author

bflad commented Mar 23, 2018

This has been released in version 1.12.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/firehose Issues and PRs that pertain to the firehose service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.12.0
Development

Successfully merging this pull request may close these issues.

Crash importing firehose delivery stream
2 participants
@bflad @radeksimko