resource/aws_spot_instance_request: Bump delete timeout to 20mins

[radeksimko]

This is mainly to address the following test failure:

=== RUN   TestAccAWSSpotInstanceRequest_NetworkInterfaceAttributes
--- FAIL: TestAccAWSSpotInstanceRequest_NetworkInterfaceAttributes (679.58s)
    testing.go:573: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
        
        Error: Error applying: 1 error(s) occurred:
        
        * aws_spot_instance_request.foo (destroy): 1 error(s) occurred:
        
        * aws_spot_instance_request.foo: Error terminating spot instance: Error waiting for instance (i-094860585f9ba7567) to terminate: timeout while waiting for state to become 'terminated' (last state: 'shutting-down', timeout: 10m0s)

I was playing with the idea of setting custom, higher timeout inside the test config, but since we get some guarantees that the instance is actually shutting down (i.e. transitioning from shutting-down to terminated) I can't think of any downside of bumping this for everyone.

I'm generally against cranking timeouts so high if it is error-based retry where the risk of false positive is much higher. This isn't the case though.

[bflad]

I'm 👍 this change -- can you update the documentation too and I'll ✅

[radeksimko]

@bflad done, PTAL. 😉

[bflad]

Call up the shipping armada! 🚢 ⚓️ ⛵️ 🛥

[bflad]

This has been released in version 1.10.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!