resource/aws_iam_user: Name change requires id to be reset

[kl4w]

addresses #2949

Ran into this the other day. Changing name on a user does not result in new entry in state after update. The Id is required to be reset after update.

make testacc TEST=./aws TESTARGS='-run=TestAccAWSUser_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSUser_ -timeout 120m
=== RUN   TestAccAWSUser_importBasic
--- PASS: TestAccAWSUser_importBasic (22.50s)
=== RUN   TestAccAWSUser_basic
--- PASS: TestAccAWSUser_basic (32.59s)
=== RUN   TestAccAWSUser_nameChange
--- PASS: TestAccAWSUser_nameChange (29.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	84.776s

[bflad]

This also relates to #2303, which we're using for consolidated discussion of the underlying issue (I closed the duplicate #2949). There are currently 3 open PRs for this issue and I'll write up full responses to each as necessary.

Other PRs:

• resource/aws_iam_user: Fix issues with update #2940
• resource/aws_iam_user: Set UserId as Id() instead of UserName #2798

[kl4w]

Ahh in my search I didn't see the other PRs. Just let me know and I'll be happy to close this in preference of one of the others.

[bflad]

@kl4w no worries and thanks for the work here! I will likely be pulling in both pull requests and testing them together since yours has an additional acceptance test. One piece we're hoping to add here as well is the following code in the resource definition to allow other downstream resources to see the ID change and not require a second plan/apply (untested):

CustomizeDiff: func(diff *schema.ResourceDiff, v interface{}) error {
    if diff.HasChange("name") || diff.HasChange("path") {
        return diff.SetNewComputed("id")
    }
    return nil
}

More soon!

[bflad]

LGTM. Thanks!

make testacc TEST=./aws TESTARGS='-run=TestAccAWSUser_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSUser_ -timeout 120m
=== RUN   TestAccAWSUser_importBasic
--- PASS: TestAccAWSUser_importBasic (10.03s)
=== RUN   TestAccAWSUser_basic
--- PASS: TestAccAWSUser_basic (12.65s)
=== RUN   TestAccAWSUser_nameChange
--- PASS: TestAccAWSUser_nameChange (15.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	37.845s

[bflad]

This is merged into master and will be released with v1.7.1, hopefully later this week.

[bflad]

This has been released in terraform-provider-aws version 1.7.1. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!