Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_appautoscaling_target: Support updating max_capacity, min_capacity, and role_arn attributes #2950

Merged
merged 1 commit into from
Jan 22, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 11, 2018

This is a simplified remake of the #2542 PR after the IAM service role changes that needed to get in as part of #2889. The basic test already handles updating the max/min capacities and checking their values in state, hence why no test changes for them. Adding a check for IAM role updates I think is a can of worms given the weird IAM service role half state in AWS at this point.

The RegisterScalableTarget API call supports updating attributes on existing targets.

Closes #240 and potentially #968

make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppautoScalingTarget'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSAppautoScalingTarget -timeout 120m
=== RUN   TestAccAWSAppautoScalingTarget_basic
--- PASS: TestAccAWSAppautoScalingTarget_basic (45.26s)
=== RUN   TestAccAWSAppautoScalingTarget_spotFleetRequest
--- PASS: TestAccAWSAppautoScalingTarget_spotFleetRequest (67.99s)
=== RUN   TestAccAWSAppautoScalingTarget_emrCluster
--- PASS: TestAccAWSAppautoScalingTarget_emrCluster (499.71s)
=== RUN   TestAccAWSAppautoScalingTarget_multipleTargets
--- PASS: TestAccAWSAppautoScalingTarget_multipleTargets (31.47s)
=== RUN   TestAccAWSAppautoScalingTarget_optionalRoleArn
--- PASS: TestAccAWSAppautoScalingTarget_optionalRoleArn (25.98s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	670.459s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/applicationautoscaling labels Jan 11, 2018
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@radeksimko radeksimko added this to the v1.8.0 milestone Jan 22, 2018
@radeksimko radeksimko changed the title r/aws_appautoscaling_target: Support updating max_capacity, min_capacity, and role_arn attributes resource/aws_appautoscaling_target: Support updating max_capacity, min_capacity, and role_arn attributes Jan 22, 2018
@bflad bflad merged commit a49f182 into master Jan 22, 2018
@bflad bflad deleted the f-aws_appautoscaling_target-allow-updates branch January 22, 2018 17:53
bflad added a commit that referenced this pull request Jan 22, 2018
@bflad
Copy link
Contributor Author

bflad commented Jan 29, 2018

This has been released in terraform-provider-aws version 1.8.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_appautoscaling_target update detaches any aws_appautoscaling_policy's
3 participants