Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_db_event_subscription: Add support of prefixes #2754

Merged
merged 4 commits into from
May 11, 2018

Conversation

ColinHebert
Copy link
Contributor

No description provided.

@jen20 jen20 added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 22, 2017
@ColinHebert ColinHebert changed the title Add support of prefixes for aws_db_event_subscription r/aws_db_event_subscription: Add support of prefixes Dec 28, 2017
@Ninir Ninir added the service/rds Issues and PRs that pertain to the rds service. label Jan 25, 2018
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Apr 26, 2018
@bflad bflad modified the milestones: v1.17.0, v1.18.0 Apr 26, 2018
@bflad bflad modified the milestones: v1.18.0, v1.19.0 May 11, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing two items in 694de77

  • Use d.Id() during read function
  • Set Computed: true on name attribute so it does not show difference after applying name_prefix
5 tests passed (all tests)
=== RUN   TestAccAWSDBEventSubscription_withSourceIds
--- PASS: TestAccAWSDBEventSubscription_withSourceIds (608.24s)
=== RUN   TestAccAWSDBEventSubscription_withPrefix
--- PASS: TestAccAWSDBEventSubscription_withPrefix (608.99s)
=== RUN   TestAccAWSDBEventSubscription_importBasic
--- PASS: TestAccAWSDBEventSubscription_importBasic (609.44s)
=== RUN   TestAccAWSDBEventSubscription_categoryUpdate
--- PASS: TestAccAWSDBEventSubscription_categoryUpdate (613.19s)
=== RUN   TestAccAWSDBEventSubscription_basicUpdate
--- PASS: TestAccAWSDBEventSubscription_basicUpdate (613.20s)

@bflad bflad merged commit 845953c into hashicorp:master May 11, 2018
bflad added a commit that referenced this pull request May 11, 2018
@bflad
Copy link
Contributor

bflad commented May 17, 2018

This has been released in version 1.19.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants