Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(region): support eu-west-3 region #2707

Closed
wants to merge 7 commits into from
Closed

feat(region): support eu-west-3 region #2707

wants to merge 7 commits into from

Conversation

VEBERArnaud
Copy link
Contributor

@VEBERArnaud VEBERArnaud commented Dec 19, 2017

Description

add support for eu-west-3 (Paris) region

WIP

some ids are still missing from aws documentation, will update this PR when available

  • hosted zone id
  • cloudtrail service account
  • elb hosted zone id
  • redshift service account
  • elb account id

Depends

Resolve

resolves #2735

@mvisonneau
Copy link

looks like https://docs.aws.amazon.com/general/latest/gr/rande.html has a bit more info but still not everything needed

@Ninir Ninir added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 19, 2017
@tsellers-r7
Copy link

Does this depend on aws-sdk-go v1.12.49? It looks like support for eu-west-3 was added there.

PR in this repo to bump aws-sdk-go to v1.12.49: PR #2706

Related PR in aws-sdk-go: aws/aws-sdk-go#1702

@jen20
Copy link
Contributor

jen20 commented Dec 20, 2017

From experimenting in the Paris region, it looks like the ELB Account ID is 009996457667, although I don't yet see this in the documentation.

@jen20
Copy link
Contributor

jen20 commented Dec 20, 2017

More interestingly, Redshift audit logging (which is the reason for requiring this AFAIK) is broken in eu-west-3. When I configure audit logging, the following happens:

Invalid principal in policy (Service: Amazon S3; Status Code: 400; Error Code: MalformedPolicy; Request ID: 042DF0CD38FA5831; S3 Extended Request ID: WOupLp4qyMYoZZiyYncnTWt5QUEtmFZZnp16HwPQuSBASWS/U5yw7Qwsnp7sE8znT9TQ/AAp3FU=) (Service: Amazon S3; Status Code: 400; Error Code: MalformedPolicy; Request ID: 042DF0CD38FA5831)

@jen20
Copy link
Contributor

jen20 commented Dec 20, 2017

It would be good if someone with support access and a vested interest in this PR could follow up with Amazon with regards to Redshift - that is the last blocker for this PR as far as I can see.

@mvisonneau
Copy link

mvisonneau commented Dec 21, 2017

Redshift service account ID has been released : http://docs.aws.amazon.com/redshift/latest/mgmt/db-auditing.html

915173422425

@jen20
Copy link
Contributor

jen20 commented Dec 21, 2017

@mvisonneau Great news! I'll look at getting this merged.

@jen20
Copy link
Contributor

jen20 commented Dec 21, 2017

@mvisonneau I'm going to pull this down locally to take it over the line.

@jen20 jen20 changed the title WIP: feat(region): support eu-west-3 region feat(region): support eu-west-3 region Dec 21, 2017
@jen20
Copy link
Contributor

jen20 commented Dec 21, 2017

This has been merged in 132d10b - thanks @VEBERArnaud and @mvisonneau! Fixes #2735,

@jen20 jen20 closed this Dec 21, 2017
@pbramy
Copy link

pbramy commented Dec 21, 2017

Great news, how should I proceed to obtain the patch ? impatient to test it and hydrate our project..

@bflad
Copy link
Contributor

bflad commented Jan 12, 2018

This has been released in terraform-provider-aws version 1.7.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@bflad bflad added this to the v1.7.0 milestone Jan 12, 2018
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provider.aws: Not a valid region: eu-west-3
7 participants