Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ecs_cluster: Add arn attribute #2552

Merged
merged 1 commit into from
Dec 6, 2017

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 5, 2017

Closes #2539

make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsCluster'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSEcsCluster -timeout 120m
=== RUN   TestAccAWSEcsCluster_basic
--- PASS: TestAccAWSEcsCluster_basic (10.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	10.425s

@Ninir Ninir added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 5, 2017
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bflad

This is looking very good, thanks for the work :) 👍

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsCluster'                          
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSEcsCluster -timeout 120m
=== RUN   TestAccAWSEcsCluster_basic
--- PASS: TestAccAWSEcsCluster_basic (13.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.030s

@Ninir Ninir merged commit fc7bff3 into hashicorp:master Dec 6, 2017
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plan failing due to aws_ecs_cluster no longer outputs arn (v0.10.8 -> v0.11.0)
2 participants