Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_network_acl_rule: Fix DiffSuppressFunc #2454

Merged
merged 1 commit into from
Oct 25, 2018
Merged

resource/aws_network_acl_rule: Fix DiffSuppressFunc #2454

merged 1 commit into from
Oct 25, 2018

Conversation

enm10k
Copy link
Contributor

@enm10k enm10k commented Nov 28, 2017

Reference #222

The following issue was already closed but it's only for one protocol.
Now the bug is not fixed for other protocols.
This code will fix it.
issue: hashicorp/terraform#13012
pr: hashicorp/terraform#13049

This is "best effort" implementations of acceptance tests.
I hope Terraform team will check this pr.

Thanks.

@Ninir Ninir added the bug Addresses a defect in current functionality. label Nov 29, 2017
@radeksimko radeksimko added service/ec2-classic service/ec2 Issues and PRs that pertain to the ec2 service. and removed service/ec2-classic labels Jan 16, 2018
@radeksimko radeksimko changed the title Fix DiffSuppressFunc in aws/resource_aws_network_acl_rule.go resource/aws_network_acl_rule: Fix DiffSuppressFunc Jan 16, 2018
@enm10k
Copy link
Contributor Author

enm10k commented Feb 4, 2018

@radeksimko
I read #222 again and now I understood this problem is not only for aws_network_acl_rule.
If anyone reviews my changes, I'll check these other resources: aws_noetwork_acl, aws_security_group, aws_security_group_rule.
I want to fix this function for my use.

@bflad bflad added this to the v1.42.0 milestone Oct 25, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, @enm10k! 🚀

--- PASS: TestAccAWSNetworkAclRule_ipv6 (7.07s)
--- PASS: TestAccAWSNetworkAclRule_allProtocol (12.26s)
--- PASS: TestAccAWSNetworkAclRule_missingParam (15.60s)
--- PASS: TestAccAWSNetworkAclRule_tcpProtocol (11.17s)
--- PASS: TestAccAWSNetworkAclRule_basic (26.18s)
--- PASS: TestAccAWSNetworkAclRule_deleteRule (25.37s)

@bflad bflad merged commit 5873d7a into hashicorp:master Oct 25, 2018
bflad added a commit that referenced this pull request Oct 25, 2018
@bflad
Copy link
Contributor

bflad commented Nov 1, 2018

This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants