Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/codeartifact_auth_token - new data source #15425

Merged
merged 7 commits into from
Oct 8, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13714

Release note for CHANGELOG:

datasource_codeartifact_authorization_token - new data source

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@DrFaust92 DrFaust92 requested a review from a team October 1, 2020 12:59
@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/codeartifact Issues and PRs that pertain to the codeartifact service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Oct 1, 2020
@DrFaust92 DrFaust92 added the new-data-source Introduces a new data source. label Oct 1, 2020
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeArtifactAuthorizationTokenDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactAuthorizationTokenDataSource_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactAuthorizationTokenDataSource_basic
--- PASS: TestAccAWSCodeArtifactAuthorizationTokenDataSource_basic (18.46s)
=== RUN   TestAccAWSCodeArtifactAuthorizationTokenDataSource_owner
--- PASS: TestAccAWSCodeArtifactAuthorizationTokenDataSource_owner (18.16s)
=== RUN   TestAccAWSCodeArtifactAuthorizationTokenDataSource_duration
--- PASS: TestAccAWSCodeArtifactAuthorizationTokenDataSource_duration (19.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	55.888s

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial

make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeArtifactAuthorizationTokenDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactAuthorizationTokenDataSource_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactAuthorizationTokenDataSource_basic
--- PASS: TestAccAWSCodeArtifactAuthorizationTokenDataSource_basic (20.94s)
=== RUN   TestAccAWSCodeArtifactAuthorizationTokenDataSource_owner
--- PASS: TestAccAWSCodeArtifactAuthorizationTokenDataSource_owner (18.68s)
=== RUN   TestAccAWSCodeArtifactAuthorizationTokenDataSource_duration
--- PASS: TestAccAWSCodeArtifactAuthorizationTokenDataSource_duration (15.76s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	56.781s

@breathingdust breathingdust added this to the v3.10.0 milestone Oct 8, 2020
@breathingdust breathingdust merged commit 4576ffd into hashicorp:master Oct 8, 2020
breathingdust added a commit that referenced this pull request Oct 8, 2020
@ghost
Copy link

ghost commented Oct 9, 2020

This has been released in version 3.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2020
@DrFaust92 DrFaust92 deleted the r/codeartifact-auth-token branch April 15, 2021 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/codeartifact Issues and PRs that pertain to the codeartifact service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AWS CodeArtifact service support
3 participants