r/glue_data_catalog_encryption_settings - new resource #14916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XL
DrFaust92
force-pushed
the
r/glue_data_catalog_encryption_settings
branch
from
17df8ab
to
737b0e7
Compare
ewbankkit
reviewed
Sep 25, 2020
|
Verified acceptance tests: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataCatalogEncryptionSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataCatalogEncryptionSettings_ -timeout 120m
=== RUN TestAccAWSDataCatalogEncryptionSettings_basic
=== PAUSE TestAccAWSDataCatalogEncryptionSettings_basic
=== CONT TestAccAWSDataCatalogEncryptionSettings_basic
--- PASS: TestAccAWSDataCatalogEncryptionSettings_basic (44.63s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 44.672s |
DrFaust92
force-pushed
the
r/glue_data_catalog_encryption_settings
branch
from
737b0e7
to
2ede994
Compare
|
@DrFaust92 Acceptance test failure: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataCatalogEncryptionSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataCatalogEncryptionSettings_ -timeout 120m
=== RUN TestAccAWSDataCatalogEncryptionSettings_basic
=== PAUSE TestAccAWSDataCatalogEncryptionSettings_basic
=== CONT TestAccAWSDataCatalogEncryptionSettings_basic
resource_aws_glue_data_catalog_encryption_settings_test.go:21: Check 5/8 error: aws_glue_data_catalog_encryption_settings.test: Attribute 'data_catalog_encryption_settings.0.connection_password_encryption.0.aws_kms_id' not found
--- FAIL: TestAccAWSDataCatalogEncryptionSettings_basic (7.86s)
FAIL
FAIL github.com/terraform-providers/terraform-provider-aws/aws 7.905s
FAIL
GNUmakefile:26: recipe for target 'testacc' failed
make: *** [testacc] Error 1 |
|
missed replaces in tests, sorry. |
ewbankkit
reviewed
Sep 30, 2020
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
|
|
ewbankkit
reviewed
Oct 1, 2020
There was a problem hiding this comment.
LGTM.
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataCatalogEncryptionSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataCatalogEncryptionSettings_ -timeout 120m
=== RUN TestAccAWSDataCatalogEncryptionSettings_basic
=== PAUSE TestAccAWSDataCatalogEncryptionSettings_basic
=== CONT TestAccAWSDataCatalogEncryptionSettings_basic
--- PASS: TestAccAWSDataCatalogEncryptionSettings_basic (45.11s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 45.158s
|
LGTM! 🚀 Thanks @DrFaust92 Verified Acceptance Tests in Commercial (us-west-2) make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataCatalogEncryptionSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataCatalogEncryptionSettings_ -timeout 120m
=== RUN TestAccAWSDataCatalogEncryptionSettings_basic
=== PAUSE TestAccAWSDataCatalogEncryptionSettings_basic
=== CONT TestAccAWSDataCatalogEncryptionSettings_basic
--- PASS: TestAccAWSDataCatalogEncryptionSettings_basic (38.55s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 40.551sVerified Acceptance Tests in GovCloud (us-gov-west-1) make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataCatalogEncryptionSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataCatalogEncryptionSettings_ -timeout 120m
=== RUN TestAccAWSDataCatalogEncryptionSettings_basic
=== PAUSE TestAccAWSDataCatalogEncryptionSettings_basic
=== CONT TestAccAWSDataCatalogEncryptionSettings_basic
--- PASS: TestAccAWSDataCatalogEncryptionSettings_basic (28.52s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 30.332s |
breathingdust
added a commit
that referenced
this pull request
Oct 1, 2020
|
This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #9736
Release note for CHANGELOG:
Output from acceptance testing: